Don't run WSOLA over always muted channels.

Don't run WSOLA over always muted channels.

WSOLA can be quite expensive to run; we should not be running it on
channels which we know are always muted due to an upmixed signal.

Not doing this results in an ~388% speedup when adjusting the
playback rate for 8 channel sources. Taking the run time for 10
seconds of audio at 2.0 rate from 11536ms (> 10 is not real time)
down to 2975ms.

This is accomplished by introducing a channel mask to the render
algorithm which can be used to generate AudioBus objects with
lower channel counts for use with the WSOLA algorithm. Masked
channels are always muted.

BUG=666813
TEST=new unittests

Committed: https://crrev.com/21d17ca06e742cbfdcaaa54e0f4964248e3fbfff
Cr-Commit-Position: refs/heads/master@{#433782}

[DaleCurtis, 2016-11-22 00:10:24]

dalecurtis@chromium.org changed reviewers:
+ sandersd@chromium.org

[sandersd (OOO until July 31), 2016-11-22 00:59:24]

lgtm

https://codereview.chromium.org/2522673003/diff/1/media/filters/audio_rendere...
File media/filters/audio_renderer_algorithm.cc (right):

https://codereview.chromium.org/2522673003/diff/1/media/filters/audio_rendere...
media/filters/audio_renderer_algorithm.cc:381: : search_block_.get(),
Nit: Simpler to understand if |reduced_search_block_| were always used.

https://codereview.chromium.org/2522673003/diff/1/media/renderers/audio_rende...
File media/renderers/audio_renderer_impl.cc (right):

https://codereview.chromium.org/2522673003/diff/1/media/renderers/audio_rende...
media/renderers/audio_renderer_impl.cc:445: [](float mix) { return !!mix; }) !=
matrix[ch].end();
Nit: Would be more clear using std::any_of().

[DaleCurtis, 2016-11-22 01:06:37]

Patchset #2 (id:20001) has been deleted

[DaleCurtis, 2016-11-22 01:07:49]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-11-22 01:07:49]

https://codereview.chromium.org/2522673003/diff/1/media/filters/audio_rendere...
File media/filters/audio_renderer_algorithm.cc (right):

https://codereview.chromium.org/2522673003/diff/1/media/filters/audio_rendere...
media/filters/audio_renderer_algorithm.cc:381: : search_block_.get(),
On 2016/11/22 at 00:59:24, sandersd wrote:
> Nit: Simpler to understand if |reduced_search_block_| were always used.

Done. Renamed to search_block_wrapper_ since it's always constructed now.

https://codereview.chromium.org/2522673003/diff/1/media/renderers/audio_rende...
File media/renderers/audio_renderer_impl.cc (right):

https://codereview.chromium.org/2522673003/diff/1/media/renderers/audio_rende...
media/renderers/audio_renderer_impl.cc:445: [](float mix) { return !!mix; }) !=
matrix[ch].end();
On 2016/11/22 at 00:59:24, sandersd wrote:
> Nit: Would be more clear using std::any_of().

Ah, didn't know about that one. Done.

[DaleCurtis, 2016-11-22 01:07:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2522673003/#ps40001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-11-22 01:08:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 01:20:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 01:20:34]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/blimp_linux_dbg...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[DaleCurtis, 2016-11-22 01:30:05]

The CQ bit was checked by dalecurtis@chromium.org

[DaleCurtis, 2016-11-22 01:30:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org
Link to the patchset: https://codereview.chromium.org/2522673003/#ps60001
(title: "Fix cast tests.")

[commit-bot: I haz the power, 2016-11-22 01:30:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 03:54:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479778205269100,
"parent_rev": "c123531d4a3ca0f2edb5cf6a5116050f8b157295", "commit_rev":
"79af72a4d937d4c290c587d76df4d84b9ea9321d"}

[commit-bot: I haz the power, 2016-11-22 03:55:06]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-22 03:58:17]

Description was changed from

==========
Don't run WSOLA over always muted channels.

WSOLA can be quite expensive to run; we should not be running it on
channels which we know are always muted due to an upmixed signal.

Not doing this results in an ~388% speedup when adjusting the
playback rate for 8 channel sources. Taking the run time for 10
seconds of audio at 2.0 rate from 11536ms (> 10 is not real time)
down to 2975ms.

This is accomplished by introducing a channel mask to the render
algorithm which can be used to generate AudioBus objects with
lower channel counts for use with the WSOLA algorithm. Masked
channels are always muted.

BUG=666813
TEST=new unittests
==========

to

==========
Don't run WSOLA over always muted channels.

WSOLA can be quite expensive to run; we should not be running it on
channels which we know are always muted due to an upmixed signal.

Not doing this results in an ~388% speedup when adjusting the
playback rate for 8 channel sources. Taking the run time for 10
seconds of audio at 2.0 rate from 11536ms (> 10 is not real time)
down to 2975ms.

This is accomplished by introducing a channel mask to the render
algorithm which can be used to generate AudioBus objects with
lower channel counts for use with the WSOLA algorithm. Masked
channels are always muted.

BUG=666813
TEST=new unittests

Committed: https://crrev.com/21d17ca06e742cbfdcaaa54e0f4964248e3fbfff
Cr-Commit-Position: refs/heads/master@{#433782}
==========

[commit-bot: I haz the power, 2016-11-22 03:58:18]

Patchset 3 (id:??) landed as
https://crrev.com/21d17ca06e742cbfdcaaa54e0f4964248e3fbfff
Cr-Commit-Position: refs/heads/master@{#433782}