Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2522653003: X87: [fullcodegen] Remove deprecated generator implementation. (Closed)

Created:
4 years, 1 month ago by zhengxing.li
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [fullcodegen] Remove deprecated generator implementation. port 09255541116e651690772f818592d5b6bef6a9d4 (r41135) original commit message: This removes the deprecated generator support for resumable functions from {FullCodeGenerator}. The existing {AstNumbering} heuristic already triggers Ignition for most resumable functions, with this change we make said heuristic a hard choice and remove the deprecated code. This also has the advantage that any suspended {JSGeneratorObject} instance on the heap is guaranteed to have code based on a bytecode array. BUG= Committed: https://crrev.com/3eff396ab0d9c0804cb8d16351ae885d0c743edc Cr-Commit-Position: refs/heads/master@{#41204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/builtins/x87/builtins-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
zhengxing.li
PTAL, thanks!
4 years, 1 month ago (2016-11-22 03:31:30 UTC) #2
chunyang.dai
lgtm
4 years, 1 month ago (2016-11-22 08:06:10 UTC) #3
Michael Starzinger
LGTM. Thanks!
4 years, 1 month ago (2016-11-22 08:50:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522653003/1
4 years ago (2016-11-23 06:53:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 07:08:57 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-23 07:09:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3eff396ab0d9c0804cb8d16351ae885d0c743edc
Cr-Commit-Position: refs/heads/master@{#41204}

Powered by Google App Engine
This is Rietveld 408576698