Only propagate intervention reports to local frames

Only propagate intervention reports to local frames

Don't try to log console messages about interventions to remote frames
(which don't support this). Instead, report the intervention to the
local root.

BUG=667481
Committed: https://crrev.com/e1eb6009ca491323f9fe18237cc2dddfc8eb399e
Cr-Commit-Position: refs/heads/master@{#434317}

[Sami, 2016-11-22 15:03:04]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 15:03:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-11-22 15:03:30]

Description was changed from

==========
Only propagate intervention reports to local frames

Don't try to log console messages about interventions to remote frames
(which don't support this). Instead, report the intervention to the
local root.

BUG=667481
==========

to

==========
Only propagate intervention reports to local frames

Don't try to log console messages about interventions to remote frames
(which don't support this). Instead, report the intervention to the
local root.

BUG=667481
==========

[Sami, 2016-11-22 15:03:30]

skyostil@chromium.org changed reviewers:
+ mkwst@chromium.org

[commit-bot: I haz the power, 2016-11-22 15:06:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 15:06:02]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sami, 2016-11-22 17:55:24]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-22 17:55:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-22 18:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-22 18:54:04]

Dry run: This issue passed the CQ dry run.

[Mike West, 2016-11-23 13:04:48]

LGTM.

[Sami, 2016-11-23 16:30:52]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-11-23 16:31:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 19:45:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 19:45:11]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sami, 2016-11-24 11:01:20]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-11-24 11:02:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 14:43:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479985280746680, "parent_rev":
"de4507de3cab4f6a2ff8ed3b442d1fb92ab94127", "commit_rev":
"b82608acdce3c38b3a8c13c94afdce4990af3063"}

[commit-bot: I haz the power, 2016-11-24 14:44:15]

Description was changed from

==========
Only propagate intervention reports to local frames

Don't try to log console messages about interventions to remote frames
(which don't support this). Instead, report the intervention to the
local root.

BUG=667481
==========

to

==========
Only propagate intervention reports to local frames

Don't try to log console messages about interventions to remote frames
(which don't support this). Instead, report the intervention to the
local root.

BUG=667481
==========

[commit-bot: I haz the power, 2016-11-24 14:44:15]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-24 14:46:20]

Description was changed from

==========
Only propagate intervention reports to local frames

Don't try to log console messages about interventions to remote frames
(which don't support this). Instead, report the intervention to the
local root.

BUG=667481
==========

to

==========
Only propagate intervention reports to local frames

Don't try to log console messages about interventions to remote frames
(which don't support this). Instead, report the intervention to the
local root.

BUG=667481

Committed: https://crrev.com/e1eb6009ca491323f9fe18237cc2dddfc8eb399e
Cr-Commit-Position: refs/heads/master@{#434317}
==========

[commit-bot: I haz the power, 2016-11-24 14:46:21]

Patchset 1 (id:??) landed as
https://crrev.com/e1eb6009ca491323f9fe18237cc2dddfc8eb399e
Cr-Commit-Position: refs/heads/master@{#434317}

[dcheng, 2016-12-27 07:56:37]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-12-27 07:56:38]

I might be missing something, but how are the interventions reported to the
local root here? It seems like it just isn't reported at all in this case.

[Sami, 2017-01-09 13:26:43]

On 2016/12/27 07:56:38, dcheng wrote:
> I might be missing something, but how are the interventions reported to the
> local root here? It seems like it just isn't reported at all in this case.

I think you're right -- we just drop the logs that are generated from
non-main-frame renderers.

I looked into fixing this but got a bit stuck: is there some object that
corresponds with the local root(s) of each renderer? I couldn't find a way to
get from WebViewImpl to the local root without recursing into the frame tree
which seems yucky. Can you think of a better idea?