Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 252263002: Initializing Bidi status members of InlineFlowBox (Closed)

Created:
6 years, 7 months ago by cmumford
Modified:
6 years, 7 months ago
Reviewers:
Nico
CC:
blink-reviews, blink-reviews-rendering, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., ojan, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Initializing Bidi status members of InlineFlowBox Valgrind complained of use before initialization so initializing InlineFlowBox's m_lineBreakBidiStatusEor, m_lineBreakBidiStatusLastStrong, and m_lineBreakBidiStatusLast to LeftToRight. BUG=368303 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/rendering/InlineFlowBox.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
cmumford
PTAL
6 years, 7 months ago (2014-04-29 17:08:56 UTC) #1
Nico
lgtm This code hasn't changed recently, I wonder why our valgrind bots don't see that. ...
6 years, 7 months ago (2014-04-29 17:16:30 UTC) #2
cmumford
On 2014/04/29 17:16:30, Nico wrote: > lgtm > > This code hasn't changed recently, I ...
6 years, 7 months ago (2014-04-29 17:50:28 UTC) #3
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 7 months ago (2014-04-30 16:25:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/252263002/1
6 years, 7 months ago (2014-04-30 16:25:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 16:56:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink
6 years, 7 months ago (2014-04-30 16:56:54 UTC) #7
cmumford
The CQ bit was checked by cmumford@chromium.org
6 years, 7 months ago (2014-04-30 17:28:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmumford@chromium.org/252263002/1
6 years, 7 months ago (2014-04-30 17:28:50 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 18:22:50 UTC) #10
Message was sent while issue was closed.
Change committed as 173008

Powered by Google App Engine
This is Rietveld 408576698