Revert of chromeos: Convert ash VPNDelegate interface to mojo

Revert of chromeos: Convert ash VPNDelegate interface to mojo (patchset #7 id:160001 of https://codereview.chromium.org/2513673004/ )

Reason for revert:
Breaks the VPN list in classic ash due to a missing entry in chrome's content browser manifest overlay. (I probably didn't catch this in manual testing due to stale generated manifest files from an earlier version of this patch.)

I will re-land with a fixed manifest file.

Original issue's description:
> chromeos: Convert ash VPNDelegate interface to mojo
>
> Under mustash the ash shell runs in a different process than chrome browser.
> Create mojo interfaces to allow chrome to tell ash about extension-based
> third-party VPN providers and to allow ash to ask chrome to open VPN config
> UI.
>
> This CL maintains the existing ash::VPNProvider struct rather than replacing
> it with ash::mojom::ThirdPartyVpnProvider because the two express different
> concepts (the former includes the built-in OpenVPN/L2TP provider and is used
> in several places in UI code). We can collapse them later.
>
> BUG=651148
> TEST=added to ash_unittests VpnListTest
>
> Committed: https://crrev.com/56e0ddccb50e0b062ea6fea8640c6dcea9ea59a7
> Cr-Commit-Position: refs/heads/master@{#434004}

TBR=stevenjb@chromium.org,sky@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651148
Committed: https://crrev.com/50f2386d5fc8b1f32aa4e1a2340e73525a1088d0
Cr-Commit-Position: refs/heads/master@{#434037}

[James Cook, 2016-11-23 00:10:39]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-11-23 00:10:40]

Created Revert of chromeos: Convert ash VPNDelegate interface to mojo

[commit-bot: I haz the power, 2016-11-23 00:11:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 00:12:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479859839486860, "parent_rev":
"a91182448cf4f6fb4089a7ea3afa1e65a4fbe4d1", "commit_rev":
"c63a0214a7350107aaffa55ef51cad8f23e19421"}

[commit-bot: I haz the power, 2016-11-23 00:12:28]

Description was changed from

==========
Revert of chromeos: Convert ash VPNDelegate interface to mojo (patchset #7
id:160001 of https://codereview.chromium.org/2513673004/ )

Reason for revert:
Breaks the VPN list in classic ash due to a missing entry in chrome's content
browser manifest overlay. (I probably didn't catch this in manual testing due to
stale generated manifest files from an earlier version of this patch.)

I will re-land with a fixed manifest file.


Original issue's description:
> chromeos: Convert ash VPNDelegate interface to mojo
> 
> Under mustash the ash shell runs in a different process than chrome browser.
> Create mojo interfaces to allow chrome to tell ash about extension-based
> third-party VPN providers and to allow ash to ask chrome to open VPN config
> UI.
> 
> This CL maintains the existing ash::VPNProvider struct rather than replacing
> it with ash::mojom::ThirdPartyVpnProvider because the two express different
> concepts (the former includes the built-in OpenVPN/L2TP provider and is used
> in several places in UI code). We can collapse them later.
> 
> BUG=651148
> TEST=added to ash_unittests VpnListTest
> 
> Committed: https://crrev.com/56e0ddccb50e0b062ea6fea8640c6dcea9ea59a7
> Cr-Commit-Position: refs/heads/master@{#434004}

TBR=stevenjb@chromium.org,sky@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651148
==========

to

==========
Revert of chromeos: Convert ash VPNDelegate interface to mojo (patchset #7
id:160001 of https://codereview.chromium.org/2513673004/ )

Reason for revert:
Breaks the VPN list in classic ash due to a missing entry in chrome's content
browser manifest overlay. (I probably didn't catch this in manual testing due to
stale generated manifest files from an earlier version of this patch.)

I will re-land with a fixed manifest file.


Original issue's description:
> chromeos: Convert ash VPNDelegate interface to mojo
> 
> Under mustash the ash shell runs in a different process than chrome browser.
> Create mojo interfaces to allow chrome to tell ash about extension-based
> third-party VPN providers and to allow ash to ask chrome to open VPN config
> UI.
> 
> This CL maintains the existing ash::VPNProvider struct rather than replacing
> it with ash::mojom::ThirdPartyVpnProvider because the two express different
> concepts (the former includes the built-in OpenVPN/L2TP provider and is used
> in several places in UI code). We can collapse them later.
> 
> BUG=651148
> TEST=added to ash_unittests VpnListTest
> 
> Committed: https://crrev.com/56e0ddccb50e0b062ea6fea8640c6dcea9ea59a7
> Cr-Commit-Position: refs/heads/master@{#434004}

TBR=stevenjb@chromium.org,sky@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651148
==========

[commit-bot: I haz the power, 2016-11-23 00:12:31]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-23 00:13:51]

Description was changed from

==========
Revert of chromeos: Convert ash VPNDelegate interface to mojo (patchset #7
id:160001 of https://codereview.chromium.org/2513673004/ )

Reason for revert:
Breaks the VPN list in classic ash due to a missing entry in chrome's content
browser manifest overlay. (I probably didn't catch this in manual testing due to
stale generated manifest files from an earlier version of this patch.)

I will re-land with a fixed manifest file.


Original issue's description:
> chromeos: Convert ash VPNDelegate interface to mojo
> 
> Under mustash the ash shell runs in a different process than chrome browser.
> Create mojo interfaces to allow chrome to tell ash about extension-based
> third-party VPN providers and to allow ash to ask chrome to open VPN config
> UI.
> 
> This CL maintains the existing ash::VPNProvider struct rather than replacing
> it with ash::mojom::ThirdPartyVpnProvider because the two express different
> concepts (the former includes the built-in OpenVPN/L2TP provider and is used
> in several places in UI code). We can collapse them later.
> 
> BUG=651148
> TEST=added to ash_unittests VpnListTest
> 
> Committed: https://crrev.com/56e0ddccb50e0b062ea6fea8640c6dcea9ea59a7
> Cr-Commit-Position: refs/heads/master@{#434004}

TBR=stevenjb@chromium.org,sky@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651148
==========

to

==========
Revert of chromeos: Convert ash VPNDelegate interface to mojo (patchset #7
id:160001 of https://codereview.chromium.org/2513673004/ )

Reason for revert:
Breaks the VPN list in classic ash due to a missing entry in chrome's content
browser manifest overlay. (I probably didn't catch this in manual testing due to
stale generated manifest files from an earlier version of this patch.)

I will re-land with a fixed manifest file.

Original issue's description:
> chromeos: Convert ash VPNDelegate interface to mojo
>
> Under mustash the ash shell runs in a different process than chrome browser.
> Create mojo interfaces to allow chrome to tell ash about extension-based
> third-party VPN providers and to allow ash to ask chrome to open VPN config
> UI.
>
> This CL maintains the existing ash::VPNProvider struct rather than replacing
> it with ash::mojom::ThirdPartyVpnProvider because the two express different
> concepts (the former includes the built-in OpenVPN/L2TP provider and is used
> in several places in UI code). We can collapse them later.
>
> BUG=651148
> TEST=added to ash_unittests VpnListTest
>
> Committed: https://crrev.com/56e0ddccb50e0b062ea6fea8640c6dcea9ea59a7
> Cr-Commit-Position: refs/heads/master@{#434004}

TBR=stevenjb@chromium.org,sky@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651148

Committed: https://crrev.com/50f2386d5fc8b1f32aa4e1a2340e73525a1088d0
Cr-Commit-Position: refs/heads/master@{#434037}
==========

[commit-bot: I haz the power, 2016-11-23 00:13:53]

Patchset 1 (id:??) landed as
https://crrev.com/50f2386d5fc8b1f32aa4e1a2340e73525a1088d0
Cr-Commit-Position: refs/heads/master@{#434037}