Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2522613003: DevTools: respect isUnderTest conditions in the browser tests. (Closed)

Created:
4 years, 1 month ago by pfeldman
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: respect isUnderTest conditions in the browser tests. BUG=664623 Committed: https://crrev.com/fc518b6f69c650b6ea9a647f07efb3d7f17b3429 Cr-Commit-Position: refs/heads/master@{#433770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -12 lines) Patch
M chrome/browser/devtools/devtools_window_testing.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js View 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 5 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Connections.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/InspectorView.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pfeldman
4 years, 1 month ago (2016-11-22 01:35:08 UTC) #2
dgozman
lgtm
4 years, 1 month ago (2016-11-22 01:40:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522613003/1
4 years, 1 month ago (2016-11-22 01:46:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 03:24:51 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 03:28:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc518b6f69c650b6ea9a647f07efb3d7f17b3429
Cr-Commit-Position: refs/heads/master@{#433770}

Powered by Google App Engine
This is Rietveld 408576698