Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 25226002: change of V8_DEPRECATED to be enabled behind a gyp flag (Closed)

Created:
7 years, 2 months ago by dcarney
Modified:
7 years, 2 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

change of V8_DEPRECATED to be enabled behind a gyp flag also add a deprecation message for newer gcc versions R=danno@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17006

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -136 lines) Patch
M Makefile View 1 chunk +4 lines, -0 lines 0 comments Download
M build/features.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M include/v8.h View 10 chunks +17 lines, -65 lines 0 comments Download
M include/v8-profiler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M include/v8config.h View 2 chunks +10 lines, -5 lines 0 comments Download
M src/api.cc View 4 chunks +0 lines, -59 lines 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcarney
ptal
7 years, 2 months ago (2013-09-30 13:14:26 UTC) #1
danno
lgtm
7 years, 2 months ago (2013-09-30 13:23:30 UTC) #2
dcarney
7 years, 2 months ago (2013-09-30 13:29:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r17006 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698