Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(693)

Unified Diff: components/browser_watcher/stability_debugging_win.cc

Issue 2522593008: Delete the stability file on clean exit. (Closed)
Patch Set: Strip extra whitespace Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/browser_watcher/stability_debugging_win.h ('k') | components/metrics/metrics_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browser_watcher/stability_debugging_win.cc
diff --git a/components/browser_watcher/stability_debugging_win.cc b/components/browser_watcher/stability_debugging_win.cc
index 804bf88d5da2a5f05e2be080d5e95957f17e0a07..3eb4e47b2affb3eac0e7f5a1995dcb4781810dbe 100644
--- a/components/browser_watcher/stability_debugging_win.cc
+++ b/components/browser_watcher/stability_debugging_win.cc
@@ -6,10 +6,14 @@
#include <string>
+#include "base/feature_list.h"
+#include "base/files/file.h"
#include "base/metrics/persistent_memory_allocator.h"
#include "base/path_service.h"
+#include "base/process/process.h"
#include "base/strings/stringprintf.h"
#include "base/time/time.h"
+#include "components/browser_watcher/features.h"
namespace browser_watcher {
@@ -60,4 +64,25 @@ base::FilePath::StringType GetStabilityFilePattern() {
base::PersistentMemoryAllocator::kFileExtension;
}
+void MarkStabilityFileForDeletion(const base::FilePath& user_data_dir) {
+ if (!base::FeatureList::IsEnabled(
+ browser_watcher::kStabilityDebuggingFeature)) {
+ return;
+ }
+
+ base::FilePath stability_file;
+ if (!GetStabilityFileForProcess(base::Process::Current(), user_data_dir,
+ &stability_file)) {
+ // TODO(manzagop): add a metric for this.
+ return;
+ }
+
+ // Open (with delete) and then immediately close the file by going out of
+ // scope. This should cause the stability debugging file to be deleted prior
+ // to the next execution.
+ base::File file(stability_file, base::File::FLAG_OPEN |
+ base::File::FLAG_READ |
+ base::File::FLAG_DELETE_ON_CLOSE);
+}
+
} // namespace browser_watcher
« no previous file with comments | « components/browser_watcher/stability_debugging_win.h ('k') | components/metrics/metrics_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698