Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 2522593008: Delete the stability file on clean exit. (Closed)
Patch Set: Introduce browser_watcher::MarkStabilityFileForDeletion Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/chrome_metrics_service_client.cc
diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc
index 2153ae594546321287b7d33a706dce169e850b76..62edba54628f9d4c8a324a54a50e76f24597da5d 100644
--- a/chrome/browser/metrics/chrome_metrics_service_client.cc
+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc
@@ -105,6 +105,7 @@
#include "chrome/common/metrics_constants_util_win.h"
#include "chrome/install_static/install_util.h"
#include "chrome/installer/util/browser_distribution.h"
+#include "components/browser_watcher/stability_debugging_win.h"
#include "components/browser_watcher/watcher_metrics_provider_win.h"
#endif
@@ -257,6 +258,7 @@ void GetExecutableVersionDetails(base::string16* product_name,
exe_file, product_name, version_number, &unused_special_build,
channel_name);
}
+
Alexei Svitkine (slow) 2016/11/22 22:22:19 Nit: Remove from the diff
manzagop (departed) 2016/11/23 16:35:49 Done.
#endif // OS_WIN
} // namespace
@@ -394,6 +396,17 @@ void ChromeMetricsServiceClient::OnLogUploadComplete() {
#endif
}
+void ChromeMetricsServiceClient::OnLogCleanShutdown() {
+#if defined(OS_WIN)
+ base::FilePath user_data_dir;
+ if (!base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir)) {
+ // TODO(manzagop): add a metric.
+ return;
+ }
+ browser_watcher::MarkStabilityFileForDeletion(user_data_dir);
+#endif // OS_WIN
+}
+
void ChromeMetricsServiceClient::InitializeSystemProfileMetrics(
const base::Closure& done_callback) {
DCHECK(initialize_task_queue_.empty());
« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | components/browser_watcher/stability_debugging_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698