Delete the stability file on clean exit.

chrome/browser/metrics/chrome_metrics_service_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/chrome_metrics_service_client.h"
 
 #include <stddef.h>
 
 #include <utility>
 #include <vector>
@@ skipping 27 matching lines @@
 #include "chrome/browser/sync/chrome_sync_client.h"
 #include "chrome/browser/ui/browser_otr_state.h"
 #include "chrome/common/channel_info.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/crash_keys.h"
 #include "chrome/common/features.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/installer/util/util_constants.h"
+#include "components/browser_watcher/features.h"
 #include "components/metrics/call_stack_profile_metrics_provider.h"
 #include "components/metrics/drive_metrics_provider.h"
 #include "components/metrics/file_metrics_provider.h"
 #include "components/metrics/gpu/gpu_metrics_provider.h"
 #include "components/metrics/metrics_pref_names.h"
 #include "components/metrics/metrics_reporting_default_state.h"
 #include "components/metrics/metrics_service.h"
 #include "components/metrics/metrics_service_client.h"
 #include "components/metrics/metrics_state_manager.h"
 #include "components/metrics/net/cellular_logic_helper.h"
@@ skipping 40 matching lines @@
 #endif
 
 #if defined(OS_WIN)
 #include <windows.h>
 
 #include "chrome/browser/metrics/antivirus_metrics_provider_win.h"
 #include "chrome/browser/metrics/google_update_metrics_provider_win.h"
 #include "chrome/common/metrics_constants_util_win.h"
 #include "chrome/install_static/install_util.h"
 #include "chrome/installer/util/browser_distribution.h"
+#include "components/browser_watcher/stability_debugging_win.h"
 #include "components/browser_watcher/watcher_metrics_provider_win.h"
 #endif
 
 #if defined(OS_WIN) || defined(OS_MACOSX)
 #include "third_party/crashpad/crashpad/client/crashpad_info.h"
 #endif
 
 #if !defined(OS_CHROMEOS)
 #include "chrome/browser/signin/chrome_signin_status_metrics_provider_delegate.h"
 #include "components/signin/core/browser/signin_status_metrics_provider.h"
@@ skipping 132 matching lines @@
   DCHECK_NE(nullptr, channel_name);
 
   wchar_t exe_file[MAX_PATH] = {};
   CHECK(::GetModuleFileName(nullptr, exe_file, arraysize(exe_file)));
 
   base::string16 unused_special_build;
   install_static::GetExecutableVersionDetails(
       exe_file, product_name, version_number, &unused_special_build,
       channel_name);
 }
+
+bool GetStabilityFilePath(base::FilePath* path) {
+  DCHECK_NE(nullptr, path);
+
+  base::FilePath user_data_dir;
+  if (!base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir))
+    return false;
+
+  return browser_watcher::GetStabilityFileForProcess(base::Process::Current(),
+                                                     user_data_dir, path);
+}
 #endif  // OS_WIN
 
 }  // namespace
 
 const char ChromeMetricsServiceClient::kBrowserMetricsName[] = "BrowserMetrics";
 
 ChromeMetricsServiceClient::ChromeMetricsServiceClient(
     metrics::MetricsStateManager* state_manager)
     : metrics_state_manager_(state_manager),
 #if defined(OS_CHROMEOS)
@@ skipping 117 matching lines @@
 #endif  // OS_WIN || OS_MACOSX
 }
 
 void ChromeMetricsServiceClient::OnLogUploadComplete() {
   // Collect time ticks stats after each UMA upload.
 #if defined(OS_WIN)
   chrome::CollectTimeTicksStats();
 #endif
 }
 
+void ChromeMetricsServiceClient::OnLogCleanShutdown() {
+#if defined(OS_WIN)
+  if (!base::FeatureList::IsEnabled(
+          browser_watcher::kStabilityDebuggingFeature)) {
+    return;
+  }
+
+  base::FilePath stability_file;
+  if (!GetStabilityFilePath(&stability_file)) {
+    // TODO(manzagop): add a metric for this.
+    return;
+  }
+
+  // Open (with delete) and then immediately close the file by going out of
+  // scope. This should cause the stability debugging file to be deleted prior
+  // to the next execution.
+  base::File file(stability_file, base::File::FLAG_OPEN |
+                                      base::File::FLAG_READ |
+                                      base::File::FLAG_DELETE_ON_CLOSE);
+#endif  // OS_WIN

[Alexei Svitkine (slow), 2016/11/22 21:29:37]

Why not have all this logic live in browser_watcher:: ?

Seems unfortunate to leak all the details such as the enabled feature and file
path into ChromeMetricsServiceClient when they could live in a more specific
place.

[manzagop (departed), 2016/11/22 22:16:09]

Done.

+}
+
 void ChromeMetricsServiceClient::InitializeSystemProfileMetrics(
     const base::Closure& done_callback) {
   DCHECK(initialize_task_queue_.empty());
 
   // Each provider's initializer takes its own "done_callback" to enable
   // asynchronously chaining. We bind |next_task| to this callback, so
   // OnInitNextTask() gets called after each initializer, and we can go through
   // successive tasks in |initialize_task_queue_|. Note that |next_task| is
   // copied by value when passed into base::Bind().
   base::Closure next_task =
@@ skipping 472 matching lines @@
   }
 }
 
 void ChromeMetricsServiceClient::OnURLOpenedFromOmnibox(OmniboxLog* log) {
   metrics_service_->OnApplicationNotIdle();
 }
 
 bool ChromeMetricsServiceClient::IsUMACellularUploadLogicEnabled() {
   return metrics::IsCellularLogicEnabled();
 }