Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 2522593007: Reenable system_health browse:social:twitter story (Closed)

Created:
4 years, 1 month ago by hjd
Modified:
4 years ago
Reviewers:
Sami, Sami (do not use)
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reenable system_health browse:social:twitter story BUG=chromium:259147 Committed: https://crrev.com/cb34998d5bc07f8dbbf9dfdce122eafe7cf6c9f3 Cr-Commit-Position: refs/heads/master@{#434507}

Patch Set 1 #

Patch Set 2 : test with new catapult #

Patch Set 3 : update to test with new catapult #

Patch Set 4 : update to test with new catapult #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tools/perf/page_sets/system_health/browsing_stories.py View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
hjd
ptal, thanks! The try jobs in #4 passed (except android_s5_perf_bisect but that was broken both ...
4 years ago (2016-11-25 11:56:33 UTC) #3
Sami
lgtm. I think S5 history by now so no need to worry about it.
4 years ago (2016-11-25 13:57:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522593007/80001
4 years ago (2016-11-25 13:59:22 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years ago (2016-11-25 15:28:19 UTC) #10
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/cb34998d5bc07f8dbbf9dfdce122eafe7cf6c9f3 Cr-Commit-Position: refs/heads/master@{#434507}
4 years ago (2016-11-25 15:30:04 UTC) #12
hjd
4 years ago (2016-12-06 11:05:59 UTC) #13
Message was sent while issue was closed.
On 2016/11/25 15:30:04, commit-bot: I haz the power wrote:
> Patchset 5 (id:??) landed as
> https://crrev.com/cb34998d5bc07f8dbbf9dfdce122eafe7cf6c9f3
> Cr-Commit-Position: refs/heads/master@{#434507}

For posterity this commit should have pointed to crbug.com/664515 not
crbug.com/259147

Powered by Google App Engine
This is Rietveld 408576698