Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2522593005: v8 inspector: do not upon empty object ids in heap profiler. (Closed)

Created:
4 years ago by pfeldman
Modified:
4 years ago
Reviewers:
alph
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

v8 inspector: do not upon empty object ids in heap profiler. BUG=chromium:651324 Committed: https://crrev.com/f0726837af84ce9a052af7c53a737754faa1be2f Cr-Commit-Position: refs/heads/master@{#41161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/inspector/v8-heap-profiler-agent-impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
pfeldman
4 years ago (2016-11-22 00:59:23 UTC) #2
alph
lgtm
4 years ago (2016-11-22 01:00:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522593005/1
4 years ago (2016-11-22 01:00:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 01:42:47 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-22 01:43:22 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0726837af84ce9a052af7c53a737754faa1be2f
Cr-Commit-Position: refs/heads/master@{#41161}

Powered by Google App Engine
This is Rietveld 408576698