third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp - Issue 2522583002: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

Issue 2522583002: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 (Closed)

Patch Set: addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorLogAgent.cpp » ('j') | third_party/inspector_protocol/lib/Values_h.template » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

index c2b616b9623016e49f52611aa04f233e2adc3c4a..eb7d4ef89816d22d1372f867206102381ad3590c 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp

@@ -488,7 +488,7 @@ Response InspectorLayerTreeAgent::snapshotCommandLog(

std::unique_ptr<protocol::Value> logValue = protocol::StringUtil::parseJSON(

snapshot->snapshotCommandLog()->toJSONString());

*commandLog =

- Array<protocol::DictionaryValue>::parse(logValue.get(), &errors);

+ Array<protocol::DictionaryValue>::fromValue(logValue.get(), &errors);

if (errors.hasErrors())

return Response::Error(errors.errors());

return Response::OK();