Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: third_party/inspector_protocol/lib/Array_h.template

Issue 2522583002: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/inspector_protocol/lib/Array_h.template
diff --git a/third_party/inspector_protocol/lib/Array_h.template b/third_party/inspector_protocol/lib/Array_h.template
index a258da1cc5630b4831b2ceb44b69074ffcfb079e..4a76d5ab2d54d22d548291e2cb15d7e84cc1312a 100644
--- a/third_party/inspector_protocol/lib/Array_h.template
+++ b/third_party/inspector_protocol/lib/Array_h.template
@@ -57,7 +57,7 @@ public:
return m_vector[index].get();
}
- std::unique_ptr<protocol::ListValue> serialize()
+ std::unique_ptr<protocol::ListValue> serializeValue()
dgozman 2016/11/22 19:39:24 Let's go for consistent naming: - serialize which
kozy 2016/11/22 21:01:26 serialize - done. toValue/fromValue - done.
{
std::unique_ptr<protocol::ListValue> result = ListValue::create();
for (auto& item : m_vector)
@@ -112,7 +112,7 @@ public:
return m_vector[index];
}
- std::unique_ptr<protocol::ListValue> serialize()
+ std::unique_ptr<protocol::ListValue> serializeValue()
{
std::unique_ptr<protocol::ListValue> result = ListValue::create();
for (auto& item : m_vector)

Powered by Google App Engine
This is Rietveld 408576698