Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: third_party/inspector_protocol/lib/FrontendChannel_h.template

Issue 2522583002: Roll third_party/inspector_protocol to 4ad35c45aca9834b67ec2cb152c816ea1b7ceb48 (Closed)
Patch Set: removed redundant new line Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/inspector_protocol/lib/FrontendChannel_h.template
diff --git a/third_party/inspector_protocol/lib/FrontendChannel_h.template b/third_party/inspector_protocol/lib/FrontendChannel_h.template
index 8b653b58214b80aaa2f288043aa45866e3346e45..77a40ec910ec9ffc55ecf398822f44af29803359 100644
--- a/third_party/inspector_protocol/lib/FrontendChannel_h.template
+++ b/third_party/inspector_protocol/lib/FrontendChannel_h.template
@@ -9,11 +9,17 @@
namespace {{namespace}} {
{% endfor %}
+class {{config.lib.export_macro}} Serializable {
+public:
+ virtual std::unique_ptr<protocol::Value> serializeValue() const = 0;
dgozman 2016/11/21 22:29:16 8 spaces?
dgozman 2016/11/21 22:29:16 Why return value and not json string? I'd call thi
kozy 2016/11/22 01:25:38 Done.
kozy 2016/11/22 01:25:38 Done.
+ virtual ~Serializable() = default;
+};
+
class {{config.lib.export_macro}} FrontendChannel {
public:
virtual ~FrontendChannel() { }
- virtual void sendProtocolResponse(int callId, const String& message) = 0;
- virtual void sendProtocolNotification(const String& message) = 0;
+ virtual void sendProtocolResponse(int callId, std::unique_ptr<Serializable> message) = 0;
+ virtual void sendProtocolNotification(std::unique_ptr<Serializable> message) = 0;
virtual void flushProtocolNotifications() = 0;
};

Powered by Google App Engine
This is Rietveld 408576698