Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2522563002: Remove unnecessary display:: namespaces. (Closed)

Created:
4 years, 1 month ago by kylechar
Modified:
4 years, 1 month ago
Reviewers:
Daniel Erat
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary display:: namespaces. There has been a lot of refactoring of display code lately. The fully qualified name display::<name> is used inside of namespace display, which is unnecessary and makes code more difficult to read. Also reflow a few poorly formatted comments in the same files. BUG=none Committed: https://crrev.com/fdae49f671258542574611acd02503720867a39a Cr-Commit-Position: refs/heads/master@{#433642}

Patch Set 1 #

Patch Set 2 : Reflow a few poorly formatted comments. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+553 lines, -627 lines) Patch
M ui/display/display_list.h View 4 chunks +12 lines, -14 lines 0 comments Download
M ui/display/display_list.cc View 4 chunks +15 lines, -16 lines 0 comments Download
M ui/display/manager/display_layout_store.h View 1 chunk +8 lines, -12 lines 0 comments Download
M ui/display/manager/display_layout_store.cc View 1 2 6 chunks +24 lines, -25 lines 0 comments Download
M ui/display/manager/display_manager.h View 1 2 13 chunks +107 lines, -123 lines 0 comments Download
M ui/display/manager/display_manager.cc View 1 2 59 chunks +206 lines, -228 lines 0 comments Download
M ui/display/manager/display_manager_utilities.h View 4 chunks +15 lines, -19 lines 0 comments Download
M ui/display/manager/display_manager_utilities.cc View 10 chunks +65 lines, -72 lines 0 comments Download
M ui/display/manager/display_manager_utilities_unittest.cc View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M ui/display/manager/managed_display_info.h View 1 5 chunks +13 lines, -19 lines 0 comments Download
M ui/display/manager/managed_display_info.cc View 1 2 15 chunks +32 lines, -35 lines 0 comments Download
M ui/display/manager/managed_display_info_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M ui/display/test/display_manager_test_api.h View 3 chunks +9 lines, -11 lines 0 comments Download
M ui/display/test/display_manager_test_api.cc View 1 2 6 chunks +36 lines, -40 lines 0 comments Download
M ui/display/test/test_screen.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
kylechar
4 years, 1 month ago (2016-11-21 18:28:18 UTC) #4
Daniel Erat
lgtm thanks for cleaning this up!
4 years, 1 month ago (2016-11-21 18:36:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522563002/60001
4 years, 1 month ago (2016-11-21 20:47:16 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 1 month ago (2016-11-21 20:53:35 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 21:00:30 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fdae49f671258542574611acd02503720867a39a
Cr-Commit-Position: refs/heads/master@{#433642}

Powered by Google App Engine
This is Rietveld 408576698