Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2522553003: Mojo C++ bindings: switch WebKit mojom targets to use STL/WTF types. (Closed)

Created:
4 years, 1 month ago by yzshen1
Modified:
4 years, 1 month ago
CC:
chromium-reviews, awdf+watch_chromium.org, iclelland+watch_chromium.org, mlamouri+watch-notifications_chromium.org, jam, chasej+watch_chromium.org, Peter Beverloo, dglazkov+blink, darin-cc_chromium.org, jkarlin+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: switch WebKit mojom targets to use STL/WTF types. BUG=624136 Committed: https://crrev.com/6b5ad7f20127c0be5ebbc168b8e4cebb38446e26 Cr-Commit-Position: refs/heads/master@{#433988}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : ' #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -63 lines) Patch
M chrome/browser/budget_service/budget_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/budget_service/budget_database_unittest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/budget_service/budget_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/background_sync/background_sync_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/background_sync/background_sync_service_impl_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/broadcast_channel/broadcast_channel_provider.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/broadcast_channel/broadcast_channel_provider.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M content/browser/hyphenation/hyphenation_impl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/hyphenation/hyphenation_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mime_registry_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/mime_registry_impl.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/notifications/blink_notification_service_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/notifications/blink_notification_service_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/notifications/type_converters.cc View 1 2 5 chunks +12 lines, -11 lines 0 comments Download
M content/renderer/background_sync/background_sync_client_impl.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/background_sync/background_sync_client_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncManager.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/background_sync/SyncManager.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp View 1 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/budget/BudgetService.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/budget/BudgetService.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 4 5 6 7 3 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 49 (37 generated)
yzshen1
Hi, Jochen. Would you please take a look? Thanks!
4 years, 1 month ago (2016-11-21 20:34:37 UTC) #10
haraken
WebKit/ LGTM
4 years, 1 month ago (2016-11-22 00:50:29 UTC) #27
yzshen1
On 2016/11/22 00:50:29, haraken wrote: > WebKit/ LGTM +Ben for content/ owner review. Thanks! (Jochen ...
4 years, 1 month ago (2016-11-22 17:47:35 UTC) #31
Ben Goodger (Google)
content lgtm
4 years, 1 month ago (2016-11-22 18:00:44 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522553003/120001
4 years, 1 month ago (2016-11-22 18:03:19 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/277892) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years, 1 month ago (2016-11-22 18:07:40 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522553003/140001
4 years, 1 month ago (2016-11-22 18:53:41 UTC) #39
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/168688)
4 years, 1 month ago (2016-11-22 19:28:20 UTC) #41
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522553003/140001
4 years, 1 month ago (2016-11-22 19:34:57 UTC) #43
commit-bot: I haz the power
Committed patchset #8 (id:140001)
4 years, 1 month ago (2016-11-22 21:38:52 UTC) #46
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/6b5ad7f20127c0be5ebbc168b8e4cebb38446e26 Cr-Commit-Position: refs/heads/master@{#433988}
4 years, 1 month ago (2016-11-22 21:41:52 UTC) #48
kolos1
4 years ago (2016-11-24 12:11:50 UTC) #49
Message was sent while issue was closed.
A revert of this CL (patchset #8 id:140001) has been created in
https://codereview.chromium.org/2525243003/ by kolos@chromium.org.

The reason for reverting is: This CL causes mojo failures on ChromeOS. See the
bug for details.

BUG=668420.

Powered by Google App Engine
This is Rietveld 408576698