Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 2522543007: Remove uses of configuration data (Closed)

Created:
4 years, 1 month ago by Brian Wilkerson
Modified:
4 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean-up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -66 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 3 chunks +2 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/source/error_processor.dart View 2 chunks +1 line, -4 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 1 7 chunks +21 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 1 11 chunks +76 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/services/lint.dart View 2 chunks +5 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/task/options.dart View 1 4 chunks +8 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 1 chunk +0 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/task/options_test.dart View 1 6 chunks +7 lines, -9 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 1 month ago (2016-11-22 18:50:29 UTC) #2
scheglov
LGTM Thanks!
4 years, 1 month ago (2016-11-22 18:54:35 UTC) #3
Brian Wilkerson
4 years, 1 month ago (2016-11-22 19:26:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e63105555b0a079c9da763c7f4bec8c7d520370c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698