Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2522543005: CC Animation: Remove redundant legacy call to UpdateActivations. (Closed)

Created:
4 years, 1 month ago by loyso (OOO)
Modified:
4 years ago
Reviewers:
ajuma, Wez
CC:
chromium-reviews, cc-bugs_chromium.org, Wez
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Remove redundant legacy call to UpdateActivations. We don't need this call. This is a legacy from LayerAnimationController. Removing it helps to avoid an unsafe pattern in WeakPtrs usage verified here: https://codereview.chromium.org/1602443003/ CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/9a57fb89b53848a2a3dfffb10ee2a95bfcb4e755 Cr-Commit-Position: refs/heads/master@{#434014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M cc/animation/element_animations.h View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/animation/element_animations.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
loyso (OOO)
4 years, 1 month ago (2016-11-22 03:15:45 UTC) #5
ajuma
lgtm
4 years, 1 month ago (2016-11-22 14:18:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522543005/1
4 years ago (2016-11-22 22:39:25 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-22 23:00:42 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-22 23:03:11 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a57fb89b53848a2a3dfffb10ee2a95bfcb4e755
Cr-Commit-Position: refs/heads/master@{#434014}

Powered by Google App Engine
This is Rietveld 408576698