Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2522543002:
Convert simple CheckedNumeric functions to constexpr (Closed)
DescriptionConvert simple CheckedNumeric functions to constexpr
NOTRY=true
TBR=tsepez@chromium.org
BUG=612995
Committed: https://crrev.com/3223ae27f45270fc80e247d473c9cb8c19e91aa8
Cr-Commit-Position: refs/heads/master@{#433775}
Patch Set 1 #Patch Set 2 : complete #
Messages
Total messages: 20 (11 generated)
Description was changed from ========== Convert simple CheckedNumeric functions to constexpr BUG=612995 ========== to ========== Convert simple CheckedNumeric functions to constexpr TBR=tsepez@chromium.org BUG=612995 ==========
jschuh@chromium.org changed reviewers: + tsepez@chromium.org
tsepez@ - These are all mechanical changes, so I was planning to TBR you and CQ it if it runs clean on a clang and gcc bot.
RS LGTM
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Convert simple CheckedNumeric functions to constexpr TBR=tsepez@chromium.org BUG=612995 ========== to ========== Convert simple CheckedNumeric functions to constexpr NOTRY=true TBR=tsepez@chromium.org BUG=612995 ==========
The CQ bit was checked by jschuh@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479785403722110,
"parent_rev": "c8a1d7d2b33b31e292c63a8dd17317e71cf17065", "commit_rev":
"a70c71180ba3de3152f256c36ae1f806a6c2cd6a"}
Message was sent while issue was closed.
Description was changed from ========== Convert simple CheckedNumeric functions to constexpr NOTRY=true TBR=tsepez@chromium.org BUG=612995 ========== to ========== Convert simple CheckedNumeric functions to constexpr NOTRY=true TBR=tsepez@chromium.org BUG=612995 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Convert simple CheckedNumeric functions to constexpr NOTRY=true TBR=tsepez@chromium.org BUG=612995 ========== to ========== Convert simple CheckedNumeric functions to constexpr NOTRY=true TBR=tsepez@chromium.org BUG=612995 Committed: https://crrev.com/3223ae27f45270fc80e247d473c9cb8c19e91aa8 Cr-Commit-Position: refs/heads/master@{#433775} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/3223ae27f45270fc80e247d473c9cb8c19e91aa8 Cr-Commit-Position: refs/heads/master@{#433775} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
