Implement initial support for nesting one ax tree in another.

content/browser/accessibility/browser_accessibility.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_
 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_
 
 #include <map>
 #include <utility>
 #include <vector>
@@ skipping 227 matching lines @@
 
   // Returns true if the bit corresponding to the given state enum is 1.
   bool HasState(ui::AXState state_enum) const;
 
   // Returns true if this node is an editable text field of any kind.
   bool IsEditableText() const;
 
   // Append the text from this node and its children.
   std::string GetTextRecursive() const;
 
+  // For an iframe element

[David Tseng, 2014/05/01 18:07:54]

nit: period and perhaps "if this element is an iframe"?

[dmazzoni, 2014/05/05 07:17:57]

Done.

+  void SetChildFrameId(int child_frame_id);

[David Tseng, 2014/05/01 18:07:54]

nit: perhaps ID?

Also, on a higher level, child frame ID to me means one child frame's id. What
about other child iframes? The naming can be confusing especially as this is the
first file I'm reviewing.

[dmazzoni, 2014/05/05 07:17:57]

Id is consistent with the rest of this file; I have no strong preference if you
want to switch to ID throughout all accessibility files.
I tried to clarify the comment a lot, see if it's more clear nw.

+
  protected:
   BrowserAccessibility();
 
   // The manager of this tree of accessibility objects.
   BrowserAccessibilityManager* manager_;
 
   // The underlying node.
   ui::AXNode* node_;
 
  private:
   // Return the sum of the lengths of all static text descendants,
   // including this object if it's static text.
   int GetStaticTextLenRecursive() const;
 
   std::string name_;
   std::string value_;
 
+  int child_frame_id_;

[David Tseng, 2014/05/01 18:07:54]

nit: did you want these sorted?

[dmazzoni, 2014/05/05 07:17:57]

I don't want to sort unrelated fields.

+
  private:

[David Tseng, 2014/05/01 18:07:54]

nit: I think the above private: specifier suffices?

[dmazzoni, 2014/05/05 07:17:57]

Done.

   DISALLOW_COPY_AND_ASSIGN(BrowserAccessibility);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_H_