Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2522503004: Start implementing search support in AnalysisDriver. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Start implementing search support in AnalysisDriver. Only local variable and label for now. More local elements and non-local search in following CLs. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/da9fcf385484f2af3289487e94c451eb7e2576e7

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -27 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 4 chunks +12 lines, -0 lines 0 comments Download
A pkg/analyzer/lib/src/dart/analysis/search.dart View 1 chunk +207 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 2 chunks +28 lines, -0 lines 1 comment Download
M pkg/analyzer/test/src/dart/analysis/index_test.dart View 1 chunk +0 lines, -27 lines 0 comments Download
A pkg/analyzer/test/src/dart/analysis/search_test.dart View 1 chunk +168 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 1 month ago (2016-11-21 20:55:31 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2522503004/diff/1/pkg/analyzer/test/src/dart/analysis/base.dart File pkg/analyzer/test/src/dart/analysis/base.dart (right): https://codereview.chromium.org/2522503004/diff/1/pkg/analyzer/test/src/dart/analysis/base.dart#newcode51 pkg/analyzer/test/src/dart/analysis/base.dart:51: expect(offset, isNonNegative, reason: "Not found '$search' in\n$testCode"); nit: ...
4 years, 1 month ago (2016-11-21 21:17:11 UTC) #2
scheglov
4 years, 1 month ago (2016-11-21 21:30:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
da9fcf385484f2af3289487e94c451eb7e2576e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698