Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 2522453002: Return after reposting BrowserChildProcessHostImpl::OnMojoError() on the right thread (Closed)

Created:
4 years, 1 month ago by o1ka
Modified:
4 years, 1 month ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, darin-cc_chromium.org, Ken Rockot(use gerrit already)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Return after reposting BrowserChildProcessHostImpl::OnMojoError() on the right thread BUG=667280 Committed: https://crrev.com/91f1d419f7cb11be2f8b6bc64109aba0b0412072 Cr-Commit-Position: refs/heads/master@{#433546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/browser_child_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
o1ka
PTAL
4 years, 1 month ago (2016-11-21 13:28:22 UTC) #4
Avi (use Gerrit)
Yikes! LGTM
4 years, 1 month ago (2016-11-21 14:44:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522453002/1
4 years, 1 month ago (2016-11-21 15:21:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 15:25:20 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/91f1d419f7cb11be2f8b6bc64109aba0b0412072 Cr-Commit-Position: refs/heads/master@{#433546}
4 years, 1 month ago (2016-11-21 15:28:30 UTC) #13
Ken Rockot(use gerrit already)
How strange, I could have sworn this was fixed months ago... On Nov 21, 2016 ...
4 years, 1 month ago (2016-11-21 15:42:26 UTC) #14
o1ka
4 years, 1 month ago (2016-11-21 16:46:49 UTC) #15
Message was sent while issue was closed.
On 2016/11/21 15:42:26, Ken Rockot wrote:
> How strange, I could have sworn this was fixed months ago...
> 
> On Nov 21, 2016 7:28 AM, mailto:"commit-bot@chromium.org via
> codereview.chromium.org" <mailto:reply@chromiumcodereview-hr.appspotmail.com>
> wrote:
> 
> > Patchset 1 (id:??) landed as
> > https://crrev.com/91f1d419f7cb11be2f8b6bc64109aba0b0412072
> > Cr-Commit-Position: refs/heads/master@{#433546}
> >
> > https://codereview.chromium.org/2522453002/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I think this code is hardly ever executed, because browser clients of Mojo
out-of-process services seem to run on IO thread (?). (I hit it in a local
experiment)

Powered by Google App Engine
This is Rietveld 408576698