Fix system-level detection in the mini_installer.

Fix system-level detection in the mini_installer.

Check for GoogleUpdateIsMachine=1 in the environment to detect
system-level operations.

BUG=667268
Committed: https://crrev.com/e3fe8957ee4142309e5becdd611ea46b96ed8bc8
Cr-Commit-Position: refs/heads/master@{#433531}

[grt (UTC plus 2), 2016-11-21 12:49:03]

The CQ bit was checked by grt@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 12:49:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[grt (UTC plus 2), 2016-11-21 12:51:21]

grt@chromium.org changed reviewers:
+ fdoray@chromium.org

[grt (UTC plus 2), 2016-11-21 12:51:22]

Hi François. PTAL. This adds some logic that's been missing from the
mini_installer for years. setup.exe checks this variable in
util/master_preferences.cc's InitializeFromCommandLine. Please take the liberty
of checking the CQ box if it looks good to you. Thanks.

[commit-bot: I haz the power, 2016-11-21 13:17:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 13:17:40]

Dry run: This issue passed the CQ dry run.

[fdoray, 2016-11-21 13:56:07]

On 2016/11/21 12:51:22, grt (UTC plus 1) wrote:
> Hi François. PTAL. This adds some logic that's been missing from the
> mini_installer for years. setup.exe checks this variable in
> util/master_preferences.cc's InitializeFromCommandLine. Please take the
liberty
> of checking the CQ box if it looks good to you. Thanks.

lgtm

setup.exe considers that the install is system-level when GoogleUpdateIsMachine
is set to "1" followed by more characters. It should check whether
GoogleUpdateIsMachine is equal to "1" like this new code, right?
https://cs.chromium.org/chromium/src/chrome/installer/util/master_preferences...

[grt (UTC plus 2), 2016-11-21 14:09:41]

On 2016/11/21 13:56:07, fdoray wrote:
> On 2016/11/21 12:51:22, grt (UTC plus 1) wrote:
> > Hi François. PTAL. This adds some logic that's been missing from the
> > mini_installer for years. setup.exe checks this variable in
> > util/master_preferences.cc's InitializeFromCommandLine. Please take the
> liberty
> > of checking the CQ box if it looks good to you. Thanks.
> 
> lgtm
> 
> setup.exe considers that the install is system-level when
GoogleUpdateIsMachine
> is set to "1" followed by more characters. It should check whether
> GoogleUpdateIsMachine is equal to "1" like this new code, right?
>
https://cs.chromium.org/chromium/src/chrome/installer/util/master_preferences...

I don't see why not. Thanks for pointing that out. I'll change that separately
since I'd like to merge this CL up through the channels.

[grt (UTC plus 2), 2016-11-21 14:09:50]

The CQ bit was checked by grt@chromium.org

[commit-bot: I haz the power, 2016-11-21 14:10:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 14:15:17]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479737390129440, "parent_rev":
["205fd5eaf5e6405d62b8b13b5e221560be9ec2cb", null], "commit_rev":
["1457ba5370a94b6f702500df03e390aea54618f9", null]}

[commit-bot: I haz the power, 2016-11-21 14:15:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-21 14:18:57]

Description was changed from

==========
Fix system-level detection in the mini_installer.

Check for GoogleUpdateIsMachine=1 in the environment to detect
system-level operations.

BUG=667268
==========

to

==========
Fix system-level detection in the mini_installer.

Check for GoogleUpdateIsMachine=1 in the environment to detect
system-level operations.

BUG=667268

Committed: https://crrev.com/e3fe8957ee4142309e5becdd611ea46b96ed8bc8
Cr-Commit-Position: refs/heads/master@{#433531}
==========

[commit-bot: I haz the power, 2016-11-21 14:18:58]

Patchset 1 (id:??) landed as
https://crrev.com/e3fe8957ee4142309e5becdd611ea46b96ed8bc8
Cr-Commit-Position: refs/heads/master@{#433531}