Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 252243003: fix cubic/line intersection; add skp tests (Closed)

Created:
6 years, 7 months ago by caryclark
Modified:
6 years, 7 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

fix cubic/line intersection; add skp tests BUG=skia:2488 TBR=reed Committed: http://code.google.com/p/skia/source/detail?r=14458

Patch Set 1 #

Patch Set 2 : bracket new test correctly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -8 lines) Patch
M src/pathops/SkDCubicLineIntersection.cpp View 1 chunk +9 lines, -2 lines 0 comments Download
M tests/PathOpsCubicLineIntersectionTest.cpp View 2 chunks +45 lines, -2 lines 0 comments Download
M tests/PathOpsExtendedTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/PathOpsOpTest.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M tests/PathOpsSkpTest.cpp View 1 1 chunk +51 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 7 months ago (2014-04-30 11:30:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/252243003/1
6 years, 7 months ago (2014-04-30 11:30:28 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-30 13:16:03 UTC) #3
commit-bot: I haz the power
Retried try job too often on Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot for step(s) BuildTests http://skia-tree-status.appspot.com/redirect/compile-buildbots/buildstatus?builder=Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot&number=2214
6 years, 7 months ago (2014-04-30 13:16:03 UTC) #4
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 7 months ago (2014-04-30 13:21:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/252243003/20001
6 years, 7 months ago (2014-04-30 13:21:44 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 13:37:57 UTC) #7
Message was sent while issue was closed. 
Change committed as 14458

Powered by Google App Engine
This is Rietveld 408576698