Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 2522423002: Check for styleResolver() in preparation for async style update. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10, nainar
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for styleResolver() in preparation for async style update. Currently, active stylesheets are appended to ScopedStyleResolver through the StyleResolver. When we move to async stylesheet update with ActiveStyleSheets being appended from StyleEngine, styleResolver() is typically null the first time we update the active stylesheets. Add a null check before accessing styleResolver() when adding @font-face rules. R=nainar@chromium.org,meade@chromium.org BUG=567021 Committed: https://crrev.com/ff9f0b0877fcbe48fef3a32fc1c86cb706764b54 Cr-Commit-Position: refs/heads/master@{#434437}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
rune
Applying the rest of my patches for 567021, it won't crash without this fix because ...
4 years ago (2016-11-24 23:35:49 UTC) #4
meade_UTC10
lgtm
4 years ago (2016-11-25 00:39:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522423002/1
4 years ago (2016-11-25 05:38:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-25 05:42:03 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-25 05:43:34 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff9f0b0877fcbe48fef3a32fc1c86cb706764b54
Cr-Commit-Position: refs/heads/master@{#434437}

Powered by Google App Engine
This is Rietveld 408576698