Revert of [stubs] KeyedStoreGeneric: inline dictionary property stores

Revert of [stubs] KeyedStoreGeneric: inline dictionary property stores (patchset #2 id:10002 of https://codereview.chromium.org/2524943002/ )

Reason for revert:
Blocks current roll:
https://codereview.chromium.org/2526753003/

Bisect results:
https://codereview.chromium.org/2531483002

Original issue's description:
> Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores
>
> For dictionary-mode receivers, the KeyedStoreGeneric stub can store
> properties directly in most cases. Doing so avoids the need to have
> an entry in the stub cache for every map/property combination.
>
> Original review: https://codereview.chromium.org/2504403005/
>
> Committed: https://crrev.com/7a963deb85a0cc04623947a759534c48e2871901
> Cr-Commit-Position: refs/heads/master@{#41218}

TBR=ishell@chromium.org,machenbach@chromium.org,jkummerow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/474bbec73dacfca83582a99a4b558af4f23db48f
Cr-Commit-Position: refs/heads/master@{#41251}

[Michael Hablich, 2016-11-24 08:30:56]

The CQ bit was checked by hablich@chromium.org

[Michael Hablich, 2016-11-24 08:30:56]

Created Revert of [stubs] KeyedStoreGeneric: inline dictionary property stores

[commit-bot: I haz the power, 2016-11-24 08:30:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 08:31:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 08:31:12]

Failed to apply patch for src/code-stub-assembler.h:
While running git apply --index -p1;
  error: patch failed: src/code-stub-assembler.h:20
  error: src/code-stub-assembler.h: patch does not apply

Patch:       src/code-stub-assembler.h
Index: src/code-stub-assembler.h
diff --git a/src/code-stub-assembler.h b/src/code-stub-assembler.h
index
488b009aa4490e8be4db20061e43bb60144b762e..e19b34dd6198d0db9a30d5d1208e6aadd8a7743a
100644
--- a/src/code-stub-assembler.h
+++ b/src/code-stub-assembler.h
@@ -20,24 +20,21 @@
 
 enum class PrimitiveType { kBoolean, kNumber, kString, kSymbol };
 
-#define HEAP_CONSTANT_LIST(V)                         \
-  V(AccessorPairMap, AccessorPairMap)                 \
-  V(BooleanMap, BooleanMap)                           \
-  V(CodeMap, CodeMap)                                 \
-  V(empty_string, EmptyString)                        \
-  V(EmptyFixedArray, EmptyFixedArray)                 \
-  V(FalseValue, False)                                \
-  V(FixedArrayMap, FixedArrayMap)                     \
-  V(FixedCOWArrayMap, FixedCOWArrayMap)               \
-  V(FixedDoubleArrayMap, FixedDoubleArrayMap)         \
-  V(FunctionTemplateInfoMap, FunctionTemplateInfoMap) \
-  V(HeapNumberMap, HeapNumberMap)                     \
-  V(MinusZeroValue, MinusZero)                        \
-  V(NanValue, Nan)                                    \
-  V(NullValue, Null)                                  \
-  V(SymbolMap, SymbolMap)                             \
-  V(TheHoleValue, TheHole)                            \
-  V(TrueValue, True)                                  \
+#define HEAP_CONSTANT_LIST(V)                 \
+  V(BooleanMap, BooleanMap)                   \
+  V(CodeMap, CodeMap)                         \
+  V(empty_string, EmptyString)                \
+  V(EmptyFixedArray, EmptyFixedArray)         \
+  V(FalseValue, False)                        \
+  V(FixedArrayMap, FixedArrayMap)             \
+  V(FixedCOWArrayMap, FixedCOWArrayMap)       \
+  V(FixedDoubleArrayMap, FixedDoubleArrayMap) \
+  V(HeapNumberMap, HeapNumberMap)             \
+  V(MinusZeroValue, MinusZero)                \
+  V(NanValue, Nan)                            \
+  V(NullValue, Null)                          \
+  V(TheHoleValue, TheHole)                    \
+  V(TrueValue, True)                          \
   V(UndefinedValue, Undefined)
 
 // Provides JavaScript-specific "macro-assembler" functionality on top of the
@@ -360,15 +357,15 @@
   // Store an array element to a FixedArray.
   compiler::Node* StoreFixedArrayElement(
       compiler::Node* object, int index, compiler::Node* value,
-      WriteBarrierMode barrier_mode = UPDATE_WRITE_BARRIER) {
-    return StoreFixedArrayElement(object, IntPtrConstant(index), value,
-                                  barrier_mode, 0, INTPTR_PARAMETERS);
+      WriteBarrierMode barrier_mode = UPDATE_WRITE_BARRIER,
+      ParameterMode parameter_mode = INTEGER_PARAMETERS) {
+    return StoreFixedArrayElement(object, Int32Constant(index), value,
+                                  barrier_mode, parameter_mode);
   }
 
   compiler::Node* StoreFixedArrayElement(
       compiler::Node* object, compiler::Node* index, compiler::Node* value,
       WriteBarrierMode barrier_mode = UPDATE_WRITE_BARRIER,
-      int additional_offset = 0,
       ParameterMode parameter_mode = INTEGER_PARAMETERS);
 
   compiler::Node* StoreFixedDoubleArrayElement(
@@ -765,35 +762,16 @@
   // Calculate a valid size for the a hash table.
   compiler::Node* HashTableComputeCapacity(compiler::Node* at_least_space_for);
 
-  template <class Dictionary>
-  compiler::Node* GetNumberOfElements(compiler::Node* dictionary);
-
-  template <class Dictionary>
-  void SetNumberOfElements(compiler::Node* dictionary,
-                           compiler::Node* num_elements_smi);
-
-  template <class Dictionary>
-  compiler::Node* GetCapacity(compiler::Node* dictionary);
-
-  template <class Dictionary>
-  compiler::Node* GetNextEnumerationIndex(compiler::Node* dictionary);
-
-  template <class Dictionary>
-  void SetNextEnumerationIndex(compiler::Node* dictionary,
-                               compiler::Node* next_enum_index_smi);
-
   // Looks up an entry in a NameDictionaryBase successor. If the entry is found
   // control goes to {if_found} and {var_name_index} contains an index of the
   // key field of the entry found. If the key is not found control goes to
   // {if_not_found}.
   static const int kInlinedDictionaryProbes = 4;
-  enum LookupMode { kFindExisting, kFindInsertionIndex };
   template <typename Dictionary>
   void NameDictionaryLookup(compiler::Node* dictionary,
                             compiler::Node* unique_name, Label* if_found,
                             Variable* var_name_index, Label* if_not_found,
-                            int inlined_probes = kInlinedDictionaryProbes,
-                            LookupMode mode = kFindExisting);
+                            int inlined_probes = kInlinedDictionaryProbes);
 
   compiler::Node* ComputeIntegerHash(compiler::Node* key, compiler::Node*
seed);
 
@@ -801,19 +779,6 @@
   void NumberDictionaryLookup(compiler::Node* dictionary,
                               compiler::Node* intptr_index, Label* if_found,
                               Variable* var_entry, Label* if_not_found);
-
-  template <class Dictionary>
-  void FindInsertionEntry(compiler::Node* dictionary, compiler::Node* key,
-                          Variable* var_key_index);
-
-  template <class Dictionary>
-  void InsertEntry(compiler::Node* dictionary, compiler::Node* key,
-                   compiler::Node* value, compiler::Node* index,
-                   compiler::Node* enum_index);
-
-  template <class Dictionary>
-  void Add(compiler::Node* dictionary, compiler::Node* key,
-           compiler::Node* value, Label* bailout);
 
   // Tries to check if {object} has own {unique_name} property.
   void TryHasOwnProperty(compiler::Node* object, compiler::Node* map,

[Michael Hablich, 2016-11-24 08:42:40]

The CQ bit was checked by hablich@chromium.org

[commit-bot: I haz the power, 2016-11-24 08:42:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 08:42:56]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479976960523300, "parent_rev":
"516817f154f265ac1c324b1a308b394c12d3c320", "commit_rev":
"036c6e0bb8ef9fb30a6cfa89543ca044d563cd0a"}

[commit-bot: I haz the power, 2016-11-24 08:43:00]

Description was changed from

==========
Revert of [stubs] KeyedStoreGeneric: inline dictionary property stores (patchset
#2 id:10002 of https://codereview.chromium.org/2524943002/ )

Reason for revert:
Blocks current roll:
https://codereview.chromium.org/2526753003/

Bisect results:
https://codereview.chromium.org/2531483002


Original issue's description:
> Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores
> 
> For dictionary-mode receivers, the KeyedStoreGeneric stub can store
> properties directly in most cases. Doing so avoids the need to have
> an entry in the stub cache for every map/property combination.
> 
> Original review: https://codereview.chromium.org/2504403005/
> 
> Committed: https://crrev.com/7a963deb85a0cc04623947a759534c48e2871901
> Cr-Commit-Position: refs/heads/master@{#41218}

TBR=ishell@chromium.org,machenbach@chromium.org,jkummerow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of [stubs] KeyedStoreGeneric: inline dictionary property stores (patchset
#2 id:10002 of https://codereview.chromium.org/2524943002/ )

Reason for revert:
Blocks current roll:
https://codereview.chromium.org/2526753003/

Bisect results:
https://codereview.chromium.org/2531483002


Original issue's description:
> Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores
> 
> For dictionary-mode receivers, the KeyedStoreGeneric stub can store
> properties directly in most cases. Doing so avoids the need to have
> an entry in the stub cache for every map/property combination.
> 
> Original review: https://codereview.chromium.org/2504403005/
> 
> Committed: https://crrev.com/7a963deb85a0cc04623947a759534c48e2871901
> Cr-Commit-Position: refs/heads/master@{#41218}

TBR=ishell@chromium.org,machenbach@chromium.org,jkummerow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-11-24 08:43:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-24 08:43:32]

Description was changed from

==========
Revert of [stubs] KeyedStoreGeneric: inline dictionary property stores (patchset
#2 id:10002 of https://codereview.chromium.org/2524943002/ )

Reason for revert:
Blocks current roll:
https://codereview.chromium.org/2526753003/

Bisect results:
https://codereview.chromium.org/2531483002


Original issue's description:
> Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores
> 
> For dictionary-mode receivers, the KeyedStoreGeneric stub can store
> properties directly in most cases. Doing so avoids the need to have
> an entry in the stub cache for every map/property combination.
> 
> Original review: https://codereview.chromium.org/2504403005/
> 
> Committed: https://crrev.com/7a963deb85a0cc04623947a759534c48e2871901
> Cr-Commit-Position: refs/heads/master@{#41218}

TBR=ishell@chromium.org,machenbach@chromium.org,jkummerow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of [stubs] KeyedStoreGeneric: inline dictionary property stores (patchset
#2 id:10002 of https://codereview.chromium.org/2524943002/ )

Reason for revert:
Blocks current roll:
https://codereview.chromium.org/2526753003/

Bisect results:
https://codereview.chromium.org/2531483002

Original issue's description:
> Reland of [stubs] KeyedStoreGeneric: inline dictionary property stores
>
> For dictionary-mode receivers, the KeyedStoreGeneric stub can store
> properties directly in most cases. Doing so avoids the need to have
> an entry in the stub cache for every map/property combination.
>
> Original review: https://codereview.chromium.org/2504403005/
>
> Committed: https://crrev.com/7a963deb85a0cc04623947a759534c48e2871901
> Cr-Commit-Position: refs/heads/master@{#41218}

TBR=ishell@chromium.org,machenbach@chromium.org,jkummerow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/474bbec73dacfca83582a99a4b558af4f23db48f
Cr-Commit-Position: refs/heads/master@{#41251}
==========

[commit-bot: I haz the power, 2016-11-24 08:43:33]

Patchset 1 (id:??) landed as
https://crrev.com/474bbec73dacfca83582a99a4b558af4f23db48f
Cr-Commit-Position: refs/heads/master@{#41251}

[Jakob Kummerow, 2016-11-24 14:52:40]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2528883003/ by jkummerow@chromium.org.

The reason for reverting is: Will fix and reland.