Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: third_party/WebKit/public/web/WebWidget.h

Issue 2522353002: Remove the CHECK in RenderWidget::GetInputMethodController (Closed)
Patch Set: Removing the override from WebFrameWidget Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/web/WebFrameWidget.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebWidget.h
diff --git a/third_party/WebKit/public/web/WebWidget.h b/third_party/WebKit/public/web/WebWidget.h
index f5733a90c9863dfec5e3a37dc65adebf98e7e5c1..8ef15d9f82b67b333f988842157101949b9ba2f2 100644
--- a/third_party/WebKit/public/web/WebWidget.h
+++ b/third_party/WebKit/public/web/WebWidget.h
@@ -232,6 +232,15 @@ class WebWidget {
// replaced.
virtual void applyReplacementRange(const WebRange&) {}
+ // Current instance of the active WebInputMethodController, that is, the
+ // WebInputMethodController corresponding to (and owned by) the focused
+ // WebLocalFrameImpl. It might return nullptr when there are no focused
+ // frames or possibly when the WebFrameWidget does not accept IME events.
+ // This should only be overrode by fame widgets.
Charlie Reis 2016/11/28 19:14:33 nit: overridden nit: frame
EhsanK 2016/11/28 19:30:18 Acknowledged.
+ virtual WebInputMethodController* getActiveWebInputMethodController() {
+ return nullptr;
+ }
+
protected:
~WebWidget() {}
};
« no previous file with comments | « third_party/WebKit/public/web/WebFrameWidget.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698