Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 2522323002: Revert of content_shell: Remove deps for resources only needed at runtime. (Closed)

Created:
4 years ago by mithro
Modified:
4 years ago
CC:
chromium-reviews, darin-cc_chromium.org, djd-OOO-Apr2017, einbinder+watch-test-runner_chromium.org, jam, jochen+watch_chromium.org, mcgreevy_go, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of content_shell: Remove deps for resources only needed at runtime. (patchset #1 id:1 of https://codereview.chromium.org/2469073004/ ) Reason for revert: Broke Mac builds of content shell. See Robert Sesek's comments. Original issue's description: > content_shell: Remove deps for resources only needed at runtime. > > https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md#data_deps_Non_linked-dependencies > > data_deps are non-linked runtime dependencies. They are built and available > > at runtime. > > The .pak and font resources are not linked but rather just needed at > runtime. > > Split out of https://codereview.chromium.org/2460503002/ > > BUG=524758 > > Committed: https://crrev.com/3d9a6345c105cd59cb62f6c5aa9649ac4560b0b0 > Cr-Commit-Position: refs/heads/master@{#429517} TBR=jochen@chromium.org,dpranke@google.com,dpranke@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=524758 Committed: https://crrev.com/fa69073c14cec82dac0bed3a16583e63f84e001b Cr-Commit-Position: refs/heads/master@{#434571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M components/test_runner/BUILD.gn View 2 chunks +6 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M content/test/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
mithro
Created Revert of content_shell: Remove deps for resources only needed at runtime.
4 years ago (2016-11-23 23:21:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522323002/1
4 years ago (2016-11-23 23:22:48 UTC) #3
Dirk Pranke
lgtm
4 years ago (2016-11-24 00:22:23 UTC) #4
mithro
On 2016/11/24 00:22:23, Dirk Pranke wrote: > lgtm I'm reverting this patch for now. I ...
4 years ago (2016-11-24 00:52:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years ago (2016-11-24 01:25:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522323002/1
4 years ago (2016-11-24 03:02:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 05:04:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522323002/1
4 years ago (2016-11-24 06:13:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-24 08:14:28 UTC) #15
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-11-24 11:56:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522323002/1
4 years ago (2016-11-25 00:55:42 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/277879)
4 years ago (2016-11-25 01:35:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522323002/1
4 years ago (2016-11-26 04:17:02 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-26 07:07:11 UTC) #24
commit-bot: I haz the power
4 years ago (2016-11-26 07:09:49 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa69073c14cec82dac0bed3a16583e63f84e001b
Cr-Commit-Position: refs/heads/master@{#434571}

Powered by Google App Engine
This is Rietveld 408576698