Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2522313003:
Check for PrintWebViewHelper validity when running nested message loops. (Closed)
DescriptionCheck for PrintWebViewHelper validity when running nested message loops.
BUG=666616
Committed: https://crrev.com/d5c9ff3d4eb3de0945a0537288a4bee31c2ee4cf
Cr-Commit-Position: refs/heads/master@{#434734}
Patch Set 1 #Patch Set 2 : self review #
Total comments: 2
Patch Set 3 : Simplify, fix build #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
lfg@chromium.org changed reviewers: + lfg@chromium.org
https://codereview.chromium.org/2522313003/diff/20001/components/printing/ren... File components/printing/renderer/print_web_view_helper.cc (left): https://codereview.chromium.org/2522313003/diff/20001/components/printing/ren... components/printing/renderer/print_web_view_helper.cc:1949: Send(msg); Wouldn't it be simpler to do: auto ptr = weak_ptr_factory_.GetWeakPtr(); Send(); if(!ptr) return;
Description was changed from ========== Use closures in PrintWebViewHelper when running nested message loops. The closures can then grab WeakPtrs to PrintWebViewHelper. BUG=666616 ========== to ========== Check for PrintWebViewHelper validity when running nested message loops. BUG=666616 ==========
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Check for PrintWebViewHelper validity when running nested message loops. BUG=666616 ========== to ========== Check for PrintWebViewHelper validity when running nested message loops. BUG=666616 ==========
PTAL https://codereview.chromium.org/2522313003/diff/20001/components/printing/ren... File components/printing/renderer/print_web_view_helper.cc (left): https://codereview.chromium.org/2522313003/diff/20001/components/printing/ren... components/printing/renderer/print_web_view_helper.cc:1949: Send(msg); On 2016/11/24 05:25:47, lfg wrote: > Wouldn't it be simpler to do: > > auto ptr = weak_ptr_factory_.GetWeakPtr(); > Send(); > if(!ptr) > return; Yes, thank you.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_x86-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
lgtm
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480356933238330,
"parent_rev": "e3c424f62f3a55ee227453c01242a73765a4a6c1", "commit_rev":
"64cc99cfa522b66d11c3da541a8e1e3089e01644"}
Message was sent while issue was closed.
Description was changed from ========== Check for PrintWebViewHelper validity when running nested message loops. BUG=666616 ========== to ========== Check for PrintWebViewHelper validity when running nested message loops. BUG=666616 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Check for PrintWebViewHelper validity when running nested message loops. BUG=666616 ========== to ========== Check for PrintWebViewHelper validity when running nested message loops. BUG=666616 Committed: https://crrev.com/d5c9ff3d4eb3de0945a0537288a4bee31c2ee4cf Cr-Commit-Position: refs/heads/master@{#434734} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/d5c9ff3d4eb3de0945a0537288a4bee31c2ee4cf Cr-Commit-Position: refs/heads/master@{#434734} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
