core/fpdfapi/parser/cpdf_stream.cpp - Issue 2522313002: Use CFX_MaybeOwned<> in fpdf_edit_create.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/parser/cpdf_stream.cpp

Issue 2522313002: Use CFX_MaybeOwned<> in fpdf_edit_create.cpp (Closed)

Patch Set: Fix botch Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/parser/cpdf_stream.cpp

diff --git a/core/fpdfapi/parser/cpdf_stream.cpp b/core/fpdfapi/parser/cpdf_stream.cpp

index 7a54fcf8ff3ef8ebc8109c0652bab8714f15dc85..de69bfae7be46d6413d94fc71c6c31535e10305f 100644

--- a/core/fpdfapi/parser/cpdf_stream.cpp

+++ b/core/fpdfapi/parser/cpdf_stream.cpp

@@ -91,7 +91,7 @@ std::unique_ptr<CPDF_Object> CPDF_Stream::CloneNonCyclic(

pNewDict = ToDictionary(

static_cast<CPDF_Object*>(pDict)->CloneNonCyclic(bDirect, pVisited));

}

- return pdfium::MakeUnique<CPDF_Stream>(acc.DetachData(), streamSize,

+ return pdfium::MakeUnique<CPDF_Stream>(acc.DetachData().release(), streamSize,

std::move(pNewDict));

}