Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6351)

Unified Diff: chrome/browser/resources/md_extensions/detail_view.js

Issue 2522303002: [MD Extensions] Add logic for opening the extension's home page (Closed)
Patch Set: closure Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/detail_view.js
diff --git a/chrome/browser/resources/md_extensions/detail_view.js b/chrome/browser/resources/md_extensions/detail_view.js
index fb4323a4fb062413c4cea71e431da2ab6c9cde8c..ba5b92fab994740c20ff466c83a234fa8304938f 100644
--- a/chrome/browser/resources/md_extensions/detail_view.js
+++ b/chrome/browser/resources/md_extensions/detail_view.js
@@ -52,6 +52,14 @@ cr.define('extensions', function() {
* @return {boolean}
* @private
*/
+ shouldShowHomepageButton_: function() {
+ return this.data.homePage.url.length > 0;
michaelpg 2016/11/28 23:09:21 nit: add a comment that we ignore |specified| beca
Devlin 2016/11/29 02:13:02 Done.
+ },
+
+ /**
+ * @return {boolean}
+ * @private
+ */
shouldShowOptionsButton_: function() {
return !!this.data.optionsPage;
},

Powered by Google App Engine
This is Rietveld 408576698