Correct EmbeddedTestServer usage in chromeos tests.

Correct EmbeddedTestServer usage in chromeos tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

This CL fixes the threading issues by either starting the server after
the handlers are added or by splitting the server start into two phases.
This is needed when the server's base URL is required for registering
the handlers.

BUG=546060
Committed: https://crrev.com/c6c3e05c26ef6aeba63e78ef06c5c4d94f75e454
Cr-Commit-Position: refs/heads/master@{#434733}

[martijnc, 2016-11-23 20:28:56]

Description was changed from

==========
Correct EmbeddedTestServer usage in chromeos tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

BUG=546060
==========

to

==========
Correct EmbeddedTestServer usage in chromeos tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

This CL fixes the threading issues by either starting the server after
the handlers are added or by splitting the server start into two phases.
This is needed when the server's base URL is required for registering
the handlers.

BUG=546060
==========

[martijnc, 2016-11-23 20:28:56]

martijn@martijnc.be changed reviewers:
+ achuith@chromium.org, rdevlin.cronin@chromium.org

[martijnc, 2016-11-23 21:22:20]

Patchset #1 (id:1) has been deleted

[martijnc, 2016-11-23 22:23:36]

martijn@martijnc.be changed reviewers:
- achuith@chromium.org, rdevlin.cronin@chromium.org

[martijnc, 2016-11-24 19:25:24]

Patchset #1 (id:20001) has been deleted

[martijnc, 2016-11-24 19:57:28]

martijn@martijnc.be changed reviewers:
+ achuith@chromium.org, reillyg@chromium.org

[martijnc, 2016-11-24 21:56:55]

achuith: can you review the browser/chromeos changes?
reillyg: can you review the browser/extensions change?

Thanks!

[achuithb, 2016-11-28 08:50:01]

On 2016/11/24 21:56:55, martijnc wrote:
> achuith: can you review the browser/chromeos changes?
> reillyg: can you review the browser/extensions change?
> 
> Thanks!

I'm happy to stamp this from an owner's perspective, but I think you need a
reviewer more familiar with EmbeddedTestServer to review this first.

[martijnc, 2016-11-28 14:26:18]

martijn@martijnc.be changed reviewers:
+ mmenke@chromium.org

[martijnc, 2016-11-28 14:26:18]

+mmenke as a net OWNER who is familiar with this. Can you take a look?

[mmenke, 2016-11-28 17:41:03]

On 2016/11/28 14:26:18, martijnc wrote:
> +mmenke as a net OWNER who is familiar with this. Can you take a look?

LGTM!

[achuithb, 2016-11-28 18:18:38]

On 2016/11/28 17:41:03, mmenke wrote:
> On 2016/11/28 14:26:18, martijnc wrote:
> > +mmenke as a net OWNER who is familiar with this. Can you take a look?
> 
> LGTM!

lgtm for c/b/cros

[Reilly Grant (use Gerrit), 2016-11-28 20:15:07]

chrome/browser/extensions lgtm

[martijnc, 2016-11-28 20:19:42]

The CQ bit was checked by martijn@martijnc.be

[martijnc, 2016-11-28 20:19:43]

Thank you!

[commit-bot: I haz the power, 2016-11-28 20:21:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 22:05:52]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480364382958550,
"parent_rev": "8ab87cc69b50ab41a42350da0537195faa6a6aa4", "commit_rev":
"e3c424f62f3a55ee227453c01242a73765a4a6c1"}

[commit-bot: I haz the power, 2016-11-28 22:06:20]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-11-28 22:08:33]

Description was changed from

==========
Correct EmbeddedTestServer usage in chromeos tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

This CL fixes the threading issues by either starting the server after
the handlers are added or by splitting the server start into two phases.
This is needed when the server's base URL is required for registering
the handlers.

BUG=546060
==========

to

==========
Correct EmbeddedTestServer usage in chromeos tests.

Adding EmbeddedTestServer handlers after the server has started isn't
thread safe.

This CL fixes the threading issues by either starting the server after
the handlers are added or by splitting the server start into two phases.
This is needed when the server's base URL is required for registering
the handlers.

BUG=546060

Committed: https://crrev.com/c6c3e05c26ef6aeba63e78ef06c5c4d94f75e454
Cr-Commit-Position: refs/heads/master@{#434733}
==========

[commit-bot: I haz the power, 2016-11-28 22:08:35]

Patchset 1 (id:??) landed as
https://crrev.com/c6c3e05c26ef6aeba63e78ef06c5c4d94f75e454
Cr-Commit-Position: refs/heads/master@{#434733}