[turbofan] Fixed divergence in escape analysis.

[turbofan] Fixed divergence in escape analysis.

This fixes a bug where the re-creation of phi nodes leads to divergence. The fix makes sure that once a node created a phi node, it sticks to it and does not forget about it, even if the inputs suddenly agree again. The bug appeared on the trybots in https://codereview.chromium.org/2512733003/.

Also I added a line to mark effect phi nodes on the queue. This is unrelated, but seems to be an obvious ommission.

R=bmeurer@chromium.org
BUG=v8:5633
Committed: https://crrev.com/14f81dd2d25508e299e392d1fad176e2c825f9d1
Cr-Commit-Position: refs/heads/master@{#41239}

[Benedikt Meurer, 2016-11-24 05:21:46]

Awesome, thanks. LGTM!

[Benedikt Meurer, 2016-11-24 05:22:42]

Description was changed from

==========
[turbofan] fixed divergence in escape analysis

This fixes a bug where the re-creation of phi nodes leads to divergence. The fix
makes sure that once a node created a phi node, it sticks to it and does not
forget about it, even if the inputs suddenly agree again. The bug appeared on
the trybots in https://codereview.chromium.org/2512733003/.

Also I added a line to mark effect phi nodes on the queue. This is unrelated,
but seems to be an obvious ommission.

R=bmeurer@chromium.org

BUG=
==========

to

==========
[turbofan] Fixed divergence in escape analysis.

This fixes a bug where the re-creation of phi nodes leads to divergence. The fix
makes sure that once a node created a phi node, it sticks to it and does not
forget about it, even if the inputs suddenly agree again. The bug appeared on
the trybots in https://codereview.chromium.org/2512733003/.

Also I added a line to mark effect phi nodes on the queue. This is unrelated,
but seems to be an obvious ommission.

R=bmeurer@chromium.org
BUG=v8:5633
==========

[Benedikt Meurer, 2016-11-24 05:22:52]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-11-24 05:22:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 05:49:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479964972354170, "parent_rev":
"d9f99dc2aecdbeafc2b4d30d9e7d5eae3fe497c5", "commit_rev":
"b62c2e00057ffa9a8843a3ab3b7f1423ce4600b9"}

[commit-bot: I haz the power, 2016-11-24 05:49:36]

Description was changed from

==========
[turbofan] Fixed divergence in escape analysis.

This fixes a bug where the re-creation of phi nodes leads to divergence. The fix
makes sure that once a node created a phi node, it sticks to it and does not
forget about it, even if the inputs suddenly agree again. The bug appeared on
the trybots in https://codereview.chromium.org/2512733003/.

Also I added a line to mark effect phi nodes on the queue. This is unrelated,
but seems to be an obvious ommission.

R=bmeurer@chromium.org
BUG=v8:5633
==========

to

==========
[turbofan] Fixed divergence in escape analysis.

This fixes a bug where the re-creation of phi nodes leads to divergence. The fix
makes sure that once a node created a phi node, it sticks to it and does not
forget about it, even if the inputs suddenly agree again. The bug appeared on
the trybots in https://codereview.chromium.org/2512733003/.

Also I added a line to mark effect phi nodes on the queue. This is unrelated,
but seems to be an obvious ommission.

R=bmeurer@chromium.org
BUG=v8:5633
==========

[commit-bot: I haz the power, 2016-11-24 05:49:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-24 05:50:05]

Description was changed from

==========
[turbofan] Fixed divergence in escape analysis.

This fixes a bug where the re-creation of phi nodes leads to divergence. The fix
makes sure that once a node created a phi node, it sticks to it and does not
forget about it, even if the inputs suddenly agree again. The bug appeared on
the trybots in https://codereview.chromium.org/2512733003/.

Also I added a line to mark effect phi nodes on the queue. This is unrelated,
but seems to be an obvious ommission.

R=bmeurer@chromium.org
BUG=v8:5633
==========

to

==========
[turbofan] Fixed divergence in escape analysis.

This fixes a bug where the re-creation of phi nodes leads to divergence. The fix
makes sure that once a node created a phi node, it sticks to it and does not
forget about it, even if the inputs suddenly agree again. The bug appeared on
the trybots in https://codereview.chromium.org/2512733003/.

Also I added a line to mark effect phi nodes on the queue. This is unrelated,
but seems to be an obvious ommission.

R=bmeurer@chromium.org
BUG=v8:5633

Committed: https://crrev.com/14f81dd2d25508e299e392d1fad176e2c825f9d1
Cr-Commit-Position: refs/heads/master@{#41239}
==========

[commit-bot: I haz the power, 2016-11-24 05:50:05]

Patchset 1 (id:??) landed as
https://crrev.com/14f81dd2d25508e299e392d1fad176e2c825f9d1
Cr-Commit-Position: refs/heads/master@{#41239}