Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2522243003: Revert of Out-of-line WTF::String's destructor. (Closed)

Created:
4 years ago by dcheng
Modified:
4 years ago
Reviewers:
esprehn, Mikhail
CC:
blink-reviews, blink-reviews-wtf_chromium.org, chromium-reviews, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Out-of-line WTF::String's destructor. (patchset #2 id:20001 of https://codereview.chromium.org/2516123002/ ) Reason for revert: 10.7% regression in blink_perf.dom =( Original issue's description: > Out-of-line WTF::String's destructor. > > This saves ~504KB in the official Linux x64 binary. > > BUG=none > > Committed: https://crrev.com/2ce3d703c50150ebe5cd6c3f1e2bf4a19f590766 > Cr-Commit-Position: refs/heads/master@{#433737} TBR=esprehn@chromium.org,mikhail.pozdnyakov@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=none Committed: https://crrev.com/292004634fa6c82d79175a774cf75f8b74944d1f Cr-Commit-Position: refs/heads/master@{#434277}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M third_party/WebKit/Source/wtf/text/WTFString.h View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/WTFString.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dcheng
Created Revert of Out-of-line WTF::String's destructor.
4 years ago (2016-11-23 19:07:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522243003/1
4 years ago (2016-11-23 19:08:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-23 23:29:56 UTC) #5
commit-bot: I haz the power
4 years ago (2016-11-23 23:32:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/292004634fa6c82d79175a774cf75f8b74944d1f
Cr-Commit-Position: refs/heads/master@{#434277}

Powered by Google App Engine
This is Rietveld 408576698