Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 252223002: Remove numeric hinttext. (Closed)

Created:
6 years, 7 months ago by rsadam
Modified:
6 years, 7 months ago
Reviewers:
bshe
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M ui/keyboard/resources/elements/kb-key.html View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/keyboard/resources/elements/kb-keyboard.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/keyboard/resources/elements/kb-keyset.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/keyboard/resources/elements/kb-keyset.js View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/keyboard/resources/layouts/qwerty.html View 1 2 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rsadam
Another mega CL - PTAL Biao!
6 years, 7 months ago (2014-04-29 15:36:05 UTC) #1
rsadam
Hey Biao! I spoke to Steve and he confirmed that the plan is still to ...
6 years, 7 months ago (2014-04-30 20:36:23 UTC) #2
bshe
On 2014/04/30 20:36:23, rsadam wrote: > Hey Biao! I spoke to Steve and he confirmed ...
6 years, 7 months ago (2014-05-02 13:58:35 UTC) #3
rsadam
Clarified with Steve and flick should be disabled for these keys, but the number value ...
6 years, 7 months ago (2014-05-02 16:53:23 UTC) #4
bshe
lgtm I suspect you may need to modify tests too if any. https://codereview.chromium.org/252223002/diff/40001/ui/keyboard/resources/layouts/qwerty.html File ui/keyboard/resources/layouts/qwerty.html ...
6 years, 7 months ago (2014-05-02 17:24:58 UTC) #5
rsadam
Done! I don't think it'll fail any tests since flick tests are currently disabled.
6 years, 7 months ago (2014-05-02 18:35:06 UTC) #6
rsadam
The CQ bit was checked by rsadam@chromium.org
6 years, 7 months ago (2014-05-02 18:35:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsadam@chromium.org/252223002/60001
6 years, 7 months ago (2014-05-02 18:37:43 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-03 02:07:17 UTC) #9
Message was sent while issue was closed.
Change committed as 268000

Powered by Google App Engine
This is Rietveld 408576698