Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 2522193002: Merged: Squashed multiple commits. (Closed)

Created:
4 years ago by vogelheim
Modified:
4 years ago
Reviewers:
Michael Hablich, marja
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: Squashed multiple commits. Merged: Return kBadChar for longest subpart of incomplete utf-8 character. Revision: fd40ebb1e64274ae3529f8bbe6dad6adc76cb391 Merged: Fix out-of-range access in unibrow::Utf8::CalculateValue. Revision: 9d524bd33dd2e8d861128499b1ffa3b3c6377628 BUG=chromium:662822, chromium:667260 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=marja@chromium.org, hablich@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/8a92864905039bfc359a9526b1aeb2085d5c00bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -302 lines) Patch
M src/unicode.cc View 3 chunks +50 lines, -73 lines 0 comments Download
M src/unicode-decoder.h View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +217 lines, -228 lines 0 comments Download
M test/unittests/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A test/unittests/unicode-unittest.cc View 1 chunk +39 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vogelheim
4 years ago (2016-11-23 10:52:57 UTC) #1
vogelheim
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years ago (2016-11-23 10:52:59 UTC) #2
marja
rubberstamp lgtm since this is a merge of already reviewed code
4 years ago (2016-11-23 11:52:53 UTC) #5
vogelheim
4 years ago (2016-11-23 11:56:03 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8a92864905039bfc359a9526b1aeb2085d5c00bf.

Powered by Google App Engine
This is Rietveld 408576698