Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2522183002: Add encode time to WebRTC telemetry tests, remove some noisy metrics. (Closed)

Created:
4 years, 1 month ago by phoglund_chromium
Modified:
4 years ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add encode time to WebRTC telemetry tests, remove some noisy metrics. Note that webrtc.stress doesn't measure stats at all (yet), so that needs to happen if we decide to go the Telemetry path. See discussion in the bug. BUG=632299 Committed: https://crrev.com/e1ccb8f91c1ad73541418436e76a748a49108061 Cr-Commit-Position: refs/heads/master@{#435012}

Patch Set 1 #

Patch Set 2 : Fixed unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -22 lines) Patch
M tools/perf/metrics/webrtc_stats.py View 3 chunks +4 lines, -12 lines 0 comments Download
M tools/perf/metrics/webrtc_stats_unittest.py View 1 2 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
phoglund_chromium
Edward: main review Annie: owner stamp
4 years ago (2016-11-25 12:11:00 UTC) #2
phoglund_chromium
ping ehmaldonado (no ping to you Annie, I know it's thanksgiving :)
4 years ago (2016-11-28 12:51:32 UTC) #3
ehmaldonado_chromium
On 2016/11/28 12:51:32, phoglund_chrome wrote: > ping ehmaldonado (no ping to you Annie, I know ...
4 years ago (2016-11-28 13:00:05 UTC) #4
sullivan
lgtm
4 years ago (2016-11-28 14:23:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522183002/1
4 years ago (2016-11-29 10:26:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/346177)
4 years ago (2016-11-29 11:14:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522183002/20001
4 years ago (2016-11-29 13:58:19 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 16:41:41 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-29 16:43:15 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e1ccb8f91c1ad73541418436e76a748a49108061
Cr-Commit-Position: refs/heads/master@{#435012}

Powered by Google App Engine
This is Rietveld 408576698