ShapeDetection: split mojom into face and barcode interfaces

ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

Java class names get s/Shape/Face/.

LayoutTests are updated to work with different mocks, one for
each service implementation.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/3868f3870f951921323c6715be6a165cb0bfc221
Cr-Commit-Position: refs/heads/master@{#434240}

[mcasas, 2016-11-23 00:37:02]

Description was changed from

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

LayoutTests are updated.

BUG=665150
==========

to

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

LayoutTests are updated.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-11-23 00:37:51]

Description was changed from

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

LayoutTests are updated.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

Java class names are s/ShapeDetection/FaceDetection/

LayoutTests are updated.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-11-23 00:39:23]

Description was changed from

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

Java class names are s/ShapeDetection/FaceDetection/

LayoutTests are updated.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

Java class names get s/Shape/Face/.

LayoutTests are updated to work with different mocks, one for
each service implementation.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[mcasas, 2016-11-23 00:42:04]

Patchset #1 (id:1) has been deleted

[mcasas, 2016-11-23 00:45:56]

Patchset #1 (id:20001) has been deleted

[mcasas, 2016-11-23 01:03:02]

mcasas@chromium.org changed reviewers:
+ xianglu@chromium.org

[mcasas, 2016-11-23 01:03:02]

xianglu@ PTAL

[mcasas, 2016-11-23 01:16:18]

Patchset #1 (id:40001) has been deleted

[mcasas, 2016-11-23 02:29:53]

mcasas@chromium.org changed reviewers:
+ haraken@chromium.org, tsepez@chromium.org

[mcasas, 2016-11-23 02:29:53]

haraken@: plz RS small changes in Source/modules/shapedetection

tsepez@: RS plz  
content_browser_manifest.json
and the mojom changes

[haraken, 2016-11-23 02:32:27]

modules/ LGTM

[xianglu, 2016-11-23 02:53:37]

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
(right):

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html:38:
}, 'Detector detect(HTMLImageElement)');
nit: Double quotes to be consistent. Quotes in other html files might be fixed
as well.

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html:61:
() => { return mockFaceDetectionReady; },
Is it possible to put mockFaceDetectionReady here directly?

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:309:
DCHECK(m_faceService.is_bound());
nit: Remove this DCHECK too?

[xianglu, 2016-11-23 05:11:20]

LGTM

[mcasas, 2016-11-23 14:49:37]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org

[mcasas, 2016-11-23 14:49:38]

avi@ RS please changes in content/

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
(right):

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html:38:
}, 'Detector detect(HTMLImageElement)');
On 2016/11/23 02:53:37, xianglu wrote:
> nit: Double quotes to be consistent. Quotes in other html files might be fixed
> as well.

Done here and in the neighbouring htmls.

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html:61:
() => { return mockFaceDetectionReady; },
On 2016/11/23 02:53:37, xianglu wrote:
> Is it possible to put mockFaceDetectionReady here directly?

Hmm, don't think so, it'd be evaluated directly
and we'd like to defer that moment.

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp (right):

https://codereview.chromium.org/2522143002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/ShapeDetector.cpp:309:
DCHECK(m_faceService.is_bound());
On 2016/11/23 02:53:37, xianglu wrote:
> nit: Remove this DCHECK too?

Yeah, this was paranoia, removed.

[Avi (use Gerrit), 2016-11-23 16:00:36]

lgtm

stamp

[Tom Sepez, 2016-11-23 16:43:15]

RS LGTM on spitting existing mojom

[mcasas, 2016-11-23 16:50:30]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-11-23 16:50:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, xianglu@chromium.org
Link to the patchset: https://codereview.chromium.org/2522143002/#ps80001
(title: "xianglu@ comments and homogenised |m_barcodeService| and
|m_faceService| usage")

[commit-bot: I haz the power, 2016-11-23 16:51:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-11-23 17:33:50]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2016-11-23 17:39:01]

Patchset #3 (id:100001) has been deleted

[mcasas, 2016-11-23 17:42:06]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-23 17:42:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2016-11-23 17:56:29]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2016-11-23 17:57:01]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2016-11-23 17:57:11]

Patchset #3 (id:120001) has been deleted

[commit-bot: I haz the power, 2016-11-23 17:57:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 19:53:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 19:53:06]

Dry run: This issue passed the CQ dry run.

[mcasas, 2016-11-23 20:15:28]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2016-11-23 20:15:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tsepez@chromium.org, avi@chromium.org,
xianglu@chromium.org
Link to the patchset: https://codereview.chromium.org/2522143002/#ps140001
(title: "Smart rebase to https://crrev.com/2527503003 (FaceDetectorOptions)")

[commit-bot: I haz the power, 2016-11-23 20:16:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 20:34:25]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1479932128075240,
"parent_rev": "d28fc88a6f0b911ba335ad62182e0c164a2128c1", "commit_rev":
"c1b6ee1ff691849da4b090510c44223c2fa815e8"}

[commit-bot: I haz the power, 2016-11-23 20:34:52]

Description was changed from

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

Java class names get s/Shape/Face/.

LayoutTests are updated to work with different mocks, one for
each service implementation.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

Java class names get s/Shape/Face/.

LayoutTests are updated to work with different mocks, one for
each service implementation.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-11-23 20:34:54]

Committed patchset #3 (id:140001)

[commit-bot: I haz the power, 2016-11-23 20:36:40]

Description was changed from

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

Java class names get s/Shape/Face/.

LayoutTests are updated to work with different mocks, one for
each service implementation.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
ShapeDetection: split mojom into face and barcode interfaces

Barcode detection for Android, currently in shapedetection.mojom, can
only be implemented in Chrome due to it using Google Play Services
(see https://crrev.com/2512123002). This CL splits the current
interface in shapedetection.mojom, which has a method for detecting
faces and another for detecting barcodes, into two .mojom files, one
for each.

Java class names get s/Shape/Face/.

LayoutTests are updated to work with different mocks, one for
each service implementation.

BUG=665150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/3868f3870f951921323c6715be6a165cb0bfc221
Cr-Commit-Position: refs/heads/master@{#434240}
==========

[commit-bot: I haz the power, 2016-11-23 20:36:41]

Patchset 3 (id:??) landed as
https://crrev.com/3868f3870f951921323c6715be6a165cb0bfc221
Cr-Commit-Position: refs/heads/master@{#434240}