Issue 252213003: Revert 266798 "[webcrypto] Make operations run on a background t..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252213003: Revert 266798 "[webcrypto] Make operations run on a background t..." (Closed)

Created:
6 years, 7 months ago by jsbell

Modified:
6 years, 7 months ago

Reviewers:
eroman

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 266798 "[webcrypto] Make operations run on a background t..." > [webcrypto] Make operations run on a background thread so they don't block the blink thread. > > More details on threading strategy provided in webcrypto_impl.cc. > > BUG=245025 > > Review URL: https://codereview.chromium.org/233733004 TBR=eroman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266903

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+382 lines, -1086 lines)			Patch
M	trunk/src/content/child/webcrypto/jwk.h	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/jwk.cc	View	4 chunks	+11 lines, -10 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/platform_crypto.h	View	12 chunks	+14 lines, -47 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/platform_crypto_nss.cc	View	49 chunks	+78 lines, -163 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/platform_crypto_openssl.cc	View	17 chunks	+33 lines, -41 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/shared_crypto.h	View	7 chunks	+18 lines, -23 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/shared_crypto.cc	View	26 chunks	+51 lines, -67 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/shared_crypto_unittest.cc	View	3 chunks	+5 lines, -128 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/status.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/webcrypto_impl.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/webcrypto_impl.cc	View	14 chunks	+133 lines, -593 lines	0 comments	Download
M	trunk/src/content/child/webcrypto/webcrypto_util.h	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	trunk/src/content/child/webcrypto/webcrypto_util.cc	View	1 chunk	+19 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jsbell

6 years, 7 months ago (2014-04-29 17:00:21 UTC) #3

Message was sent while issue was closed.

Revert due to a large number of layout test crashes in crypto/

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40...

Expand Messages | Collapse Messages