Issue 252213002: Hide some more heap allocators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 252213002: Hide some more heap allocators. (Closed)

Created:
6 years, 7 months ago by Yang

Modified:
6 years, 7 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Hide some more heap allocators. R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21069

Patch Set 2 : yes we can! #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -80 lines)			Patch
M	src/heap.h	View		4 chunks	+46 lines, -60 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+0 lines, -12 lines	0 comments	Download
M	test/cctest/cctest.h	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-mark-compact.cc	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/252213002/diff/1/test/cctest/cctest.h File test/cctest/cctest.h (right): https://codereview.chromium.org/252213002/diff/1/test/cctest/cctest.h#newcode93 test/cctest/cctest.h:93: using i::Heap::AllocateFixedArray; nit: Can we alpha-sort all of ...

6 years, 7 months ago (2014-04-29 16:43:20 UTC) #2

Yang

6 years, 7 months ago (2014-04-30 06:26:58 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r21069 (presubmit successful).

Expand Messages | Collapse Messages

Issue 252213002: Hide some more heap allocators. (Closed)

Description

Patch Set 1 #

Patch Set 2 : yes we can! #

Messages