Issue 25221002: Remove ArrayBufferView::BaseAddress method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25221002: Remove ArrayBufferView::BaseAddress method. (Closed)

Created:
7 years, 2 months ago by Dmitry Lomov (no reviews)

Modified:
7 years, 2 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove ArrayBufferView::BaseAddress method. We should not expose a raw pointer to typed array's backing store. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16999

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -13 lines)			Patch
	M	include/v8.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	src/api.cc	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

On 2013/09/30 08:01:13, Dmitry Lomov (chromium) wrote: > PTAL lgtm if this doesn't break anything.

7 years, 2 months ago (2013-09-30 09:06:55 UTC) #2

Dmitry Lomov (no reviews)

7 years, 2 months ago (2013-09-30 09:31:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16999 (presubmit successful).