Add variadic helper functions for CheckedNumeric math operations

base/numerics/safe_numerics_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <limits>
 #include <type_traits>
 
@@ skipping 800 matching lines @@
 
   CheckedNumeric<int> too_large = std::numeric_limits<int>::max();
   EXPECT_TRUE(too_large.IsValid());
   too_large += d;
   EXPECT_FALSE(too_large.IsValid());
   too_large -= d;
   EXPECT_FALSE(too_large.IsValid());
   too_large /= d;
   EXPECT_FALSE(too_large.IsValid());
 }
+
+TEST(SafeNumerics, VariadicNumericOperations) {
+  auto a = base::CheckedAdd(1, 2UL, 3LL, 4).ValueOrDie();

[Tom Sepez, 2016/11/23 16:52:06]

Can we throw a checked numeric argument into each of these cases?

[jschuh, 2016/11/23 19:18:00]

Sounds good. I was going to add a simple wrapper template function for cases
like this, so might as well do it here.

[jschuh, 2016/11/23 21:49:22]

Done.

+  EXPECT_EQ(static_cast<decltype(a)>(10), a);
+  auto b = base::CheckedSub(20, 2UL, 4).ValueOrDie();
+  EXPECT_EQ(static_cast<decltype(b)>(14.0), b);
+  auto c = base::CheckedMul(20, 1, 5, 3UL).ValueOrDie();
+  EXPECT_EQ(static_cast<decltype(c)>(300.0), c);
+  auto d = base::CheckedDiv(20, 2.0, 5LL, -4).ValueOrDie();
+  EXPECT_EQ(static_cast<decltype(d)>(-.5), d);
+  auto e = base::CheckedMod(20, 3).ValueOrDie();
+  EXPECT_EQ(static_cast<decltype(e)>(2), e);
+  auto f = base::CheckedLsh(1, 2).ValueOrDie();
+  EXPECT_EQ(static_cast<decltype(f)>(4), f);
+  auto g = base::CheckedRsh(4, 2).ValueOrDie();
+  EXPECT_EQ(static_cast<decltype(g)>(1), g);
+  auto h =
+      base::CheckedRsh(base::CheckedAdd(1, 1, 1, 1), base::CheckedSub(4, 2))
+          .ValueOrDie();
+  EXPECT_EQ(static_cast<decltype(h)>(1), h);
+}