chrome/browser/android/offline_pages/prerendering_offliner_factory.cc - Issue 2522073002: [OfflinePages] RequestCoordinatorFactory return null for incognito

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner_factory.cc

Issue 2522073002: [OfflinePages] RequestCoordinatorFactory return null for incognito (Closed)

Patch Set: Merge Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_utils.cc ('k') | chrome/browser/android/offline_pages/request_coordinator_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/prerendering_offliner_factory.cc

diff --git a/chrome/browser/android/offline_pages/prerendering_offliner_factory.cc b/chrome/browser/android/offline_pages/prerendering_offliner_factory.cc

index 1695f8b21576a51e60ec88c3557b2cede860252c..a3af00c54d437d388ce6a4ae6c78274c9fe0b396 100644

--- a/chrome/browser/android/offline_pages/prerendering_offliner_factory.cc

+++ b/chrome/browser/android/offline_pages/prerendering_offliner_factory.cc

@@ -34,7 +34,8 @@ Offliner* PrerenderingOfflinerFactory::GetOffliner(

// Get a pointer to the (unowned) offline page model.

OfflinePageModel* model =

OfflinePageModelFactory::GetInstance()->GetForBrowserContext(context_);

+ // Ensure we do have a model for saving a page if we prerender it.

+ DCHECK(model) << "No OfflinePageModel for offliner";

offliner_ = new PrerenderingOffliner(context_, policy, model);

}