Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2363)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java

Issue 2522053002: WebView: don't allow processes to share data dir. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java
index d6366358b075700f7067328bb71bfea30c0b4e31..fc2cdfde850cf648b28c7fd842cac3d45082606c 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java
@@ -13,9 +13,10 @@ import android.os.IBinder;
import android.os.Parcel;
import android.os.Process;
import android.os.RemoteException;
+import android.test.suitebuilder.annotation.LargeTest;
import org.chromium.android_webview.AwBrowserProcess;
-import org.chromium.base.test.util.DisabledTest;
+import org.chromium.base.test.util.Feature;
import java.util.concurrent.Callable;
import java.util.concurrent.CountDownLatch;
@@ -41,24 +42,15 @@ public class AwSecondBrowserProcessTest extends AwTestBase {
super.tearDown();
}
- /*
- * @LargeTest
- * @Feature({"AndroidWebView"})
- * We can't test that creating second browser
- * process succeeds either, because in debug it will crash due to an assert
- * in the SQL DB code.
- */
- @DisabledTest(message = "crbug.com/582146")
+ @LargeTest
+ @Feature({"AndroidWebView"})
public void testCreatingSecondBrowserProcessFails() throws Throwable {
startSecondBrowserProcess();
assertFalse(tryStartingBrowserProcess());
}
- /*
- * @LargeTest
- * @Feature({"AndroidWebView"})
- */
- @DisabledTest
+ @LargeTest
+ @Feature({"AndroidWebView"})
public void testLockCleanupOnProcessShutdown() throws Throwable {
startSecondBrowserProcess();
assertFalse(tryStartingBrowserProcess());

Powered by Google App Engine
This is Rietveld 408576698