Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2522043003: Replace ASSERT_NOT_REACHED -> NOTREACHED (Closed)

Created:
4 years ago by Yoonjae
Modified:
4 years ago
Reviewers:
kouhei (in TOK), yoonjae.cho92
CC:
chromium-reviews, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, fs, gyuyoung2, dglazkov+blink, krit, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, f(malita), Stephen Chennney, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, blink-reviews-layout_chromium.org, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED -> NOTREACHED BUG=596760 Committed: https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f Cr-Commit-Position: refs/heads/master@{#434601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M third_party/WebKit/Source/core/css/CSSSelector.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFace.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/StyleRule.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/BarProp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/style/ShapeValue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAngle.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPoint.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGString.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (12 generated)
Yoonjae
@kouhei PTAL.
4 years ago (2016-11-23 08:38:24 UTC) #2
kouhei (in TOK)
Would you update the CL title+desc that this CL is about replacing ASSERT_NOT_REACHED -> NOTREACHED ...
4 years ago (2016-11-28 01:59:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2522043003/1
4 years ago (2016-11-28 04:26:13 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 04:30:40 UTC) #15
commit-bot: I haz the power
4 years ago (2016-11-28 04:33:39 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b12c489b9a470b61f23de3aa27c627eb3a733b4f
Cr-Commit-Position: refs/heads/master@{#434601}

Powered by Google App Engine
This is Rietveld 408576698