Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 25220002: [CSS Regions] Layout Test for selection direction (Closed)

Created:
7 years, 2 months ago by Manuel Rego
Modified:
7 years, 2 months ago
Reviewers:
ojan
CC:
blink-reviews, chromiumbugtracker_adobe.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[CSS Regions] Layout Test for selection direction Patch already landed in WebKit. See http://trac.webkit.org/changeset/155974 Selection follows DOM tree, so the highlighted text in this test case is the opposite to what the user is actually selecting. This was not working properly from r139197 to r158274, so adding a Layout Test to prevent future breaks. It is a reftest comparing regions and absolute positions behavior. Test: fast/regions/selection-direction.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A LayoutTests/fast/regions/selection-direction.html View 1 chunk +48 lines, -0 lines 0 comments Download
A LayoutTests/fast/regions/selection-direction-expected.html View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Manuel Rego
7 years, 2 months ago (2013-09-30 07:59:23 UTC) #1
ojan
lgtm
7 years, 2 months ago (2013-09-30 23:32:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rego@igalia.com/25220002/1
7 years, 2 months ago (2013-09-30 23:33:18 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-01 04:37:12 UTC) #4
Message was sent while issue was closed.
Change committed as 158588

Powered by Google App Engine
This is Rietveld 408576698