Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.cpp

Issue 2521993003: Send boundary events before gotpointercapture (Closed)
Patch Set: Fix the tests Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/input/PointerEventManager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/PointerEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.cpp b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
index 0bcf7c11529c4b7b3fd0878fcd6a1016c996284f..cd712a0aa20d040b680e41b8613a9e07cda1c708 100644
--- a/third_party/WebKit/Source/core/input/PointerEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
@@ -574,16 +574,16 @@ void PointerEventManager::processPendingPointerCapture(
m_pointerEventFactory.createPointerCaptureEvent(
pointerEvent, EventTypeNames::lostpointercapture));
}
- // Note that If pendingPointerCaptureTarget is null dispatchPointerEvent
- // automatically does nothing.
- dispatchPointerEvent(pendingPointerCaptureTarget,
- m_pointerEventFactory.createPointerCaptureEvent(
- pointerEvent, EventTypeNames::gotpointercapture));
- if (pendingPointerCaptureTarget)
+ if (pendingPointerCaptureTarget) {
+ setNodeUnderPointer(pointerEvent, pendingPointerCaptureTarget);
+ dispatchPointerEvent(pendingPointerCaptureTarget,
+ m_pointerEventFactory.createPointerCaptureEvent(
+ pointerEvent, EventTypeNames::gotpointercapture));
m_pointerCaptureTarget.set(pointerId, pendingPointerCaptureTarget);
- else
+ } else {
m_pointerCaptureTarget.remove(pointerId);
+ }
}
void PointerEventManager::removeTargetFromPointerCapturingMapping(
@@ -697,8 +697,4 @@ bool PointerEventManager::primaryPointerdownCanceled(
return false;
}
-EventTarget* PointerEventManager::getMouseCapturingNode() {
- return getCapturingNode(PointerEventFactory::s_mouseId);
-}
-
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/input/PointerEventManager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698