Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2521973002: [wasm] Fix {InstantiateAsmJs} builtin on x64. (Closed)

Created:
4 years, 1 month ago by Michael Starzinger
Modified:
4 years, 1 month ago
Reviewers:
bradnelson, neis
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix {InstantiateAsmJs} builtin on x64. This makes sure the {kScratchRegister} is not used across macro instructions (e.g. {LeaveFrame}) that would clobber its content. Generally it is highly unsafe to use such scratch registers with a life-range spanning macro instructions. R=neis@chromium.org Committed: https://crrev.com/5894d0e46130ff08eb4a645e63cbc028b9735513 Cr-Commit-Position: refs/heads/master@{#41181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M src/builtins/x64/builtins-x64.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Michael Starzinger
Georg: PTAL. Brad: FYI.
4 years, 1 month ago (2016-11-22 13:23:48 UTC) #4
neis
lgtm, thanks.
4 years, 1 month ago (2016-11-22 13:36:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2521973002/1
4 years, 1 month ago (2016-11-22 13:52:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 13:54:37 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 13:54:59 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5894d0e46130ff08eb4a645e63cbc028b9735513
Cr-Commit-Position: refs/heads/master@{#41181}

Powered by Google App Engine
This is Rietveld 408576698