Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2521943002: Return one U+fffd for longest subpart of incomplete utf-8 character. (Closed)

Created:
4 years, 1 month ago by vogelheim
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Return one U+fffd for longest subpart of incomplete utf-8 character. This brings the utf-8 decoder in line w/ the Unicode spec recommendation, and also with the utf-8 decoder in V8. This latter bit is the motivation for this change, since either this or the v8 utf-8 decoder gets used for JavaScript source code, and they should agree with each other. More details + spec references in the bug. BUG=chromium:662822 Review-Url: https://codereview.chromium.org/2498653002 Cr-Commit-Position: refs/heads/master@{#432470} (cherry picked from commit 9a8c03cf61f42e45e4c4d2362d97cc2c5abbdc1f) Committed: https://chromium.googlesource.com/chromium/src/+/cc60468fe8bd421e7e41914992d877a2a1398991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -23 lines) Patch
M third_party/WebKit/LayoutTests/fast/encoding/char-decoding-invalid-trail.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/text/TextCodecUTF8.cpp View 9 chunks +34 lines, -21 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
vogelheim
4 years, 1 month ago (2016-11-22 11:00:40 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc60468fe8bd421e7e41914992d877a2a1398991.

Powered by Google App Engine
This is Rietveld 408576698